960039 - Remove unused `charging` attribute from status bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Maciej Małecki]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140110030650

Steps to reproduce:

Look at the markup for status bar.


Actual results:

Noticed non-standard and apparently not used `charging` attribute.


Expected results:

There should be no `charging` attribute.

Comment 1

[Maciej Małecki]

Attachment: Patch

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8360388 [details] [review]
Patch

Hi, the patch looks good, however you need to rebase your branch before I could merge it.

Please do the following to update your pull request:

git checkout master
git remote add upstream https://github.com/mozilla-b2g/gaia.git # assuming you haven't done so.
git pull upstream master
git checkout remove-charging-attribute
git rebase master
<resolving conflict, following screen direction>
git push -f origin remove-charging-attribute

Comment 3

[Maciej Małecki]

Thanks for review Tim! I pushed the rebased version.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8360388 [details] [review]
Patch

Looks good! I will merge the commit after Travis CI come back green.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/fecb15413917f16938a4963157584568d7d19017