Closed
Bug 960047
Opened 11 years ago
Closed 11 years ago
Sync banner promo links in bookmark/add-on panels need to continue working; consider re-setting sync counts
Categories
(Firefox :: General, defect, P2)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 30
People
(Reporter: Gavin, Assigned: mak)
References
Details
(Whiteboard: p=1 s=it-30c-29a-28b.3 [qa!])
Attachments
(1 file, 1 obsolete file)
3.60 KB,
patch
|
Gavin
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Two concerns raised by Marco in bug 958300 comment 1:
- We have "Hey, set up sync" promo banners in the "add bookmark" and "remember password" panels (see bug 618913), those should continue to work with the new sync setup flow
- We only show those panels 5 times (and allow users to explicitly close them to prevent them from hiding them again). We may want to consider re-setting the "don't show anymore" prefs on upgrade to new-sync to re-promote the feature?
Assignee | ||
Comment 1•11 years ago
|
||
we also show the promobox when installing add-ons (if add-ons sync is not enabled)
Updated•11 years ago
|
Whiteboard: [qa+]
Reporter | ||
Updated•11 years ago
|
Blocks: fxdesktopbacklog
Updated•11 years ago
|
Whiteboard: [qa+] → [qa+] p=0
Updated•11 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Whiteboard: [qa+] p=0 → p=1 s=it-30c-29a-28b.2 [qa+]
Updated•11 years ago
|
QA Contact: twalker
Assignee | ||
Comment 2•11 years ago
|
||
So, first of all, these are the links we have in the promo banners, they should be verified and eventually corrected if they are not what we expect, please let me know if we should change some of the interactions here.
Appears on the "Remember Password for this site" doorhanger if Sync is disabled:
- You can access your passwords on all your devices with Sync. Learn More
clicking Learn More goes to https://services.mozilla.com/sync/
Appears on the Star panel when editing an already starred bookmark if Sync is disabled:
- You can access your bookmarks on all your devices with Sync. Learn More
clicking Learn More goes to https://services.mozilla.com/sync/
Appears on the install add-on doorhanger if Sync is disabled:
- You can access your add-ons on all your devices with %S. Learn More
clicking Learn More goes to https://services.mozilla.com/sync/
Appears on the install add-on doorhanger if Sync is enabled but add-ons are not synced:
- You can use your Sync account to synchronize add-ons across multiple devices. Learn More
clicking Learn More goes to https://support.mozilla.org/kb/how-do-i-enable-add-sync
Ryan, could you please check which of these wording/links should be changed, or redirect to someone who could?
Flags: needinfo?(rfeeley)
Assignee | ||
Comment 3•11 years ago
|
||
this is the patch to reset the counters and start showing the promobox again.
Reporter | ||
Updated•11 years ago
|
Priority: -- → P2
Assignee | ||
Comment 4•11 years ago
|
||
John, could you please check comment 2 and let me know which of that wording/link I should change?
Flags: needinfo?(rfeeley) → needinfo?(jgruen)
Reporter | ||
Comment 5•11 years ago
|
||
Too late to change the wording for 29, but thankfully those look OK. We're going to need to adjust the links probably, but let's not block this bug on that. I'll file a separate bug to track it.
Flags: needinfo?(jgruen)
Reporter | ||
Comment 6•11 years ago
|
||
Bug 972524 covers sumo, I filed bug 978346 for mozilla.org (which is where the services.mozilla.com links currently redirect to).
Comment 7•11 years ago
|
||
Carry over to Iteration it-30c-29a-28b.3
Whiteboard: p=1 s=it-30c-29a-28b.2 [qa+] → p=1 s=it-30c-29a-28b.3 [qa+]
Assignee | ||
Updated•11 years ago
|
Updated•11 years ago
|
Whiteboard: p=1 s=it-30c-29a-28b.3 [qa+] → p=1 [qa+]
Reporter | ||
Comment 8•11 years ago
|
||
Comment on attachment 8381495 [details] [diff] [review]
patch v1
I think we won't need to change the links after all. Let's get this patch landed and then resolve this.
Assignee | ||
Comment 9•11 years ago
|
||
OK, the patch will need an unbitrot since I see someone already added migration 21. Will do that asap.
Assignee | ||
Comment 10•11 years ago
|
||
just an unbitrot
Attachment #8381495 -
Attachment is obsolete: true
Attachment #8389861 -
Flags: review?(gavin.sharp)
Reporter | ||
Updated•11 years ago
|
Attachment #8389861 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/50734f7aa80d
I assume this should get uplifted to Aurora soon.
Target Milestone: --- → Firefox 30
Reporter | ||
Comment 12•11 years ago
|
||
Yes please!
status-firefox29:
--- → affected
tracking-firefox29:
--- → +
Reporter | ||
Updated•11 years ago
|
Attachment #8389861 -
Flags: approval-mozilla-aurora+
Updated•11 years ago
|
Whiteboard: p=1 [qa+] → p=1 s=it-30c-29a-28b.3 [qa+]
Assignee | ||
Comment 13•11 years ago
|
||
Comment 14•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-firefox30:
--- → fixed
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Whiteboard: p=1 s=it-30c-29a-28b.3 [qa+] → p=1 s=it-30c-29a-28b.3 [qa!]
Updated•11 years ago
|
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
You need to log in
before you can comment on or make changes to this bug.
Description
•