Sync banner promo links in bookmark/add-on panels need to continue working; consider re-setting sync counts

VERIFIED FIXED in Firefox 29

Status

()

Firefox
General
P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Gavin, Assigned: mak)

Tracking

Trunk
Firefox 30
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox29+ verified, firefox30 verified)

Details

(Whiteboard: p=1 s=it-30c-29a-28b.3 [qa!])

Attachments

(1 attachment, 1 obsolete attachment)

Two concerns raised by Marco in bug 958300 comment 1:

- We have "Hey, set up sync" promo banners in the "add bookmark" and "remember password" panels (see bug 618913), those should continue to work with the new sync setup flow

- We only show those panels 5 times (and allow users to explicitly close them to prevent them from hiding them again). We may want to consider re-setting the "don't show anymore" prefs on upgrade to new-sync to re-promote the feature?
(Assignee)

Comment 1

4 years ago
we also show the promobox when installing add-ons (if add-ons sync is not enabled)
Whiteboard: [qa+]
Blocks: 969593
Blocks: 950073

Updated

4 years ago
Whiteboard: [qa+] → [qa+] p=0

Updated

4 years ago
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Whiteboard: [qa+] p=0 → p=1 s=it-30c-29a-28b.2 [qa+]

Updated

4 years ago
QA Contact: twalker
(Assignee)

Comment 2

4 years ago
So, first of all, these are the links we have in the promo banners, they should be verified and eventually corrected if they are not what we expect, please let me know if we should change some of the interactions here.

Appears on the "Remember Password for this site" doorhanger if Sync is disabled:
- You can access your passwords on all your devices with Sync. Learn More
  clicking Learn More goes to https://services.mozilla.com/sync/

Appears on the Star panel when editing an already starred bookmark if Sync is disabled:
- You can access your bookmarks on all your devices with Sync. Learn More
  clicking Learn More goes to https://services.mozilla.com/sync/

Appears on the install add-on doorhanger if Sync is disabled:
- You can access your add-ons on all your devices with %S. Learn More
  clicking Learn More goes to https://services.mozilla.com/sync/

Appears on the install add-on doorhanger if Sync is enabled but add-ons are not synced:
- You can use your Sync account to synchronize add-ons across multiple devices. Learn More
  clicking Learn More goes to https://support.mozilla.org/kb/how-do-i-enable-add-sync

Ryan, could you please check which of these wording/links should be changed, or redirect to someone who could?
Flags: needinfo?(rfeeley)
(Assignee)

Comment 3

4 years ago
Created attachment 8381495 [details] [diff] [review]
patch v1

this is the patch to reset the counters and start showing the promobox again.
Priority: -- → P2
(Assignee)

Comment 4

4 years ago
John, could you please check comment 2 and let me know which of that wording/link I should change?
Flags: needinfo?(rfeeley) → needinfo?(jgruen)
Too late to change the wording for 29, but thankfully those look OK. We're going to need to adjust the links probably, but let's not block this bug on that. I'll file a separate bug to track it.
Flags: needinfo?(jgruen)
Bug 972524 covers sumo, I filed bug 978346 for mozilla.org (which is where the services.mozilla.com links currently redirect to).
Carry over to Iteration it-30c-29a-28b.3
Whiteboard: p=1 s=it-30c-29a-28b.2 [qa+] → p=1 s=it-30c-29a-28b.3 [qa+]
(Assignee)

Updated

4 years ago
Depends on: 977472, 972524

Updated

4 years ago
Whiteboard: p=1 s=it-30c-29a-28b.3 [qa+] → p=1 [qa+]
Comment on attachment 8381495 [details] [diff] [review]
patch v1

I think we won't need to change the links after all. Let's get this patch landed and then resolve this.
(Assignee)

Comment 9

4 years ago
OK, the patch will need an unbitrot since I see someone already added migration 21. Will do that asap.
(Assignee)

Comment 10

4 years ago
Created attachment 8389861 [details] [diff] [review]
patch v1

just an unbitrot
Attachment #8381495 - Attachment is obsolete: true
Attachment #8389861 - Flags: review?(gavin.sharp)
Attachment #8389861 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 11

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/50734f7aa80d

I assume this should get uplifted to Aurora soon.
Target Milestone: --- → Firefox 30
Yes please!
status-firefox29: --- → affected
tracking-firefox29: --- → +
Attachment #8389861 - Flags: approval-mozilla-aurora+

Updated

4 years ago
Whiteboard: p=1 [qa+] → p=1 s=it-30c-29a-28b.3 [qa+]
(Assignee)

Comment 13

4 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/84cf5af0d833
status-firefox29: affected → fixed
https://hg.mozilla.org/mozilla-central/rev/50734f7aa80d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
status-firefox30: --- → fixed

Updated

4 years ago
Status: RESOLVED → VERIFIED
status-firefox29: fixed → verified
status-firefox30: fixed → verified
Whiteboard: p=1 s=it-30c-29a-28b.3 [qa+] → p=1 s=it-30c-29a-28b.3 [qa!]

Updated

4 years ago
No longer blocks: 950073
Flags: firefox-backlog+
You need to log in before you can comment on or make changes to this bug.