Closed Bug 960170 Opened 10 years ago Closed 10 years ago

[Calendar][Integration Test] use chai.assert instead of regular assert for better error messages

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mmedeiros, Assigned: mmedeiros)

Details

Attachments

(1 file)

Link to github pull request
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review 
in some cases bugs only happens during a travis build, and the log in a few cases isn't as helpful as possible.

chai is being used by other tests, so I think we should reuse it on marionette tests as well.

the error message:

> "content is bigger than container: expected 271 to equal 270"

is more helpful than:

> "AssertionError: content is bigger than container"
Assignee: nobody → mmedeiros

        Attachment #8360553 -
        Flags: review?(gaye)

    
    

    
  
Merged onto master https://github.com/mozilla-b2g/gaia/commit/24372b8fda1f11228fdab55099fdf39f7bb8bf3d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

        Attachment #8360553 -
        Flags: review?(gaye) → review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: