960171 - Collections.synchronizedMap is unnecessary in PanelManager

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

See bug 958192 comment 12.

Comment 1

[raymond [:retornam] (inactive)]

Attachment: bug-960171.patch

Comment 2

[:Margaret Leibovic]

Comment on attachment 8361191 [details] [diff] [review]
bug-960171.patch

Review of attachment 8361191 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/PanelManager.java
@@ -46,5 @@
>  
>      private static AtomicInteger sRequestId = new AtomicInteger(0);
>  
>      // Stores set of pending request callbacks.
> -    private static final Map<Integer, RequestCallback> sCallbacks = Collections.synchronizedMap(new HashMap<Integer, RequestCallback>());

You should also remove the Collections import at the top of the file.

Comment 3

[Vivek Balakrishnan[:vivek]]

I would like to take this as my first bug. can you assign this to me?

Comment 4

[raymond [:retornam] (inactive)]

Attachment: bug-960171.patch

Comment 5

[:Margaret Leibovic]

(In reply to vivek from comment #3)
> I would like to take this as my first bug. can you assign this to me?

Thanks for offering to help! Unfortunately, Raymond has already started working on this bug - you can see he's in the "Assigned To" field, and he's been uploading patches.

However, there are plenty of bugs to go around! Let us know if you need help finding another one.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8363079 [details] [diff] [review]
bug-960171.patch

Thanks!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/530cd49cb5d8

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/530cd49cb5d8