Closed
Bug 960171
Opened 10 years ago
Closed 10 years ago
Collections.synchronizedMap is unnecessary in PanelManager
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: Margaret, Unassigned)
References
Details
(Whiteboard: [good first bug][lang=java][mentor=bnicholson])
Attachments
(1 file, 1 obsolete file)
1.73 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Updated•10 years ago
|
Assignee: nobody → mozbugs.retornam
Comment 1•10 years ago
|
||
Attachment #8361191 -
Flags: review?(margaret.leibovic)
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8361191 [details] [diff] [review] bug-960171.patch Review of attachment 8361191 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/home/PanelManager.java @@ -46,5 @@ > > private static AtomicInteger sRequestId = new AtomicInteger(0); > > // Stores set of pending request callbacks. > - private static final Map<Integer, RequestCallback> sCallbacks = Collections.synchronizedMap(new HashMap<Integer, RequestCallback>()); You should also remove the Collections import at the top of the file.
Attachment #8361191 -
Flags: review?(margaret.leibovic) → review+
Comment 3•10 years ago
|
||
I would like to take this as my first bug. can you assign this to me?
Comment 4•10 years ago
|
||
Attachment #8361191 -
Attachment is obsolete: true
Attachment #8363079 -
Flags: review?(margaret.leibovic)
Reporter | ||
Comment 5•10 years ago
|
||
(In reply to vivek from comment #3) > I would like to take this as my first bug. can you assign this to me? Thanks for offering to help! Unfortunately, Raymond has already started working on this bug - you can see he's in the "Assigned To" field, and he's been uploading patches. However, there are plenty of bugs to go around! Let us know if you need help finding another one.
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8363079 [details] [diff] [review] bug-960171.patch Thanks!
Attachment #8363079 -
Flags: review?(margaret.leibovic) → review+
Reporter | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/530cd49cb5d8
Keywords: checkin-needed
Whiteboard: [good first bug][lang=java][mentor=bnicholson] → [good first bug][lang=java][mentor=bnicholson][fixed-in-fx-team]
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/530cd49cb5d8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=java][mentor=bnicholson][fixed-in-fx-team] → [good first bug][lang=java][mentor=bnicholson]
Target Milestone: --- → Firefox 29
Updated•10 years ago
|
Assignee: mozbugs.retornam → nobody
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•