Fix settings scrolling test

RESOLVED FIXED

Status

Testing Graveyard
Eideticker
RESOLVED FIXED
4 years ago
5 months ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We broke this test again with the changes from bug 942826. Before that, prepare_app was called after launch, but now prepare_app takes care of the launch. This test doesn't really even need a prepare_app as this code can just go into launch_app. I also noticed that we scroll down but not up on latest builds.
(Assignee)

Comment 1

4 years ago
Created attachment 8360560 [details] [diff] [review]
Fix settings scrolling test. v1.0
Attachment #8360560 - Flags: review?(wlachance)
Comment on attachment 8360560 [details] [diff] [review]
Fix settings scrolling test. v1.0

Review of attachment 8360560 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM minus some stray print statements

::: src/tests/b2g/appscrolling/settings.py
@@ +12,5 @@
>          settings_container = self.device.marionette.find_element(
>              By.CSS_SELECTOR, '#root > div')
> +        header = self.device.marionette.find_element(
> +            By.CSS_SELECTOR, '#root > header')
> +        print header.size

Debugging code?

@@ +17,2 @@
>          settings_location = settings_container.location
> +        print settings_location

Ditto?
Attachment #8360560 - Flags: review?(wlachance) → review+
(Assignee)

Comment 3

4 years ago
Landed in:
https://github.com/mozilla/eideticker/commit/bbd2e50fd0b8a8c92c9f2b59963cd9e56cbd9404
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

5 months ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.