Closed
Bug 960185
Opened 12 years ago
Closed 12 years ago
Fix settings scrolling test
Categories
(Testing Graveyard :: Eideticker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davehunt, Assigned: davehunt)
Details
Attachments
(1 file)
|
1.59 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
We broke this test again with the changes from bug 942826. Before that, prepare_app was called after launch, but now prepare_app takes care of the launch. This test doesn't really even need a prepare_app as this code can just go into launch_app. I also noticed that we scroll down but not up on latest builds.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8360560 -
Flags: review?(wlachance)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8360560 [details] [diff] [review]
Fix settings scrolling test. v1.0
Review of attachment 8360560 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM minus some stray print statements
::: src/tests/b2g/appscrolling/settings.py
@@ +12,5 @@
> settings_container = self.device.marionette.find_element(
> By.CSS_SELECTOR, '#root > div')
> + header = self.device.marionette.find_element(
> + By.CSS_SELECTOR, '#root > header')
> + print header.size
Debugging code?
@@ +17,2 @@
> settings_location = settings_container.location
> + print settings_location
Ditto?
Attachment #8360560 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•