Closed
Bug 960215
Opened 10 years ago
Closed 10 years ago
[B2G][Messages] Image-attachment does not fill the screen in landscape orientation
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)
People
(Reporter: nkot, Assigned: johnhu)
References
Details
(Keywords: regression)
Attachments
(3 files)
Description: When the user opens up an image/attachment(MMS) and rotates the screen to landscape orientation the image will not fill the screen. Repro Steps: 1) Updated Buri to BuildID: 20140115041401 2) Receive an MMS - image 3) Open Messages app 4) Tap to open image attachment 5) Rotate device to landscape orientation Actual: The screen will rotate but the image wont fill the screen, will display in the corner Expected: Image will fit the screen nicely Environmental Variables: Device: Buri v1.4 (master) Mozilla RIL BuildID: 20140115041401 Gaia: 255a56ac67e5b28f1fc78307969cc83391c9652f Gecko: 81bced59e8b3 Version: 29.0a1 Firmware Version: v1.2-device.cfg Notes: have tried on v1.3, the image cannot be rotated to landscape Repro frequency: 100% See attached screenshot
This also occurs with email attachments.
Updated•10 years ago
|
blocking-b2g: --- → 1.4?
Comment 2•10 years ago
|
||
Does this reproduce on 1.3?
Component: Gaia::SMS → Gaia::Gallery
Keywords: qawanted
Comment 3•10 years ago
|
||
Confirmed that, as stated in the notes Comment 0, received MMS photos can not be rotated to landscape mode on 1.3. So this issue does not reproduce in 1.3. Also checked the 1.4 build from the 1st, and it behaved like 1.3, so this is very recent regression. 1.4 Environmental Variables : Device: Buri v1.4 Mozilla RIL BuildID: 20140116040206 Gaia: 82878ba16172213cd00ba3e8b377564b290e59c1 Gecko: 324e2cba1029 Version: 29.0a1 Base Image: V1.2-device.cfg
Comment 4•10 years ago
|
||
Regression Window: Last Working Environmental Variables: Device: Buri v1.4 Mozilla RIL BuildID: 20140109040203 Gaia: 47206ac66b084c6f6c4503a3b10d0e0760df2b6f Gecko: 9409405e0739 Version: 29.0a1 Base Image: V1.2-device.cfg First Broken Environmental Variables: Device: Buri v1.4 Mozilla RIL BuildID: 20140110040206 Gaia: f400efc804366c7b7cf5476d1d5d325e6651ee71 Gecko: 37516445a0b5 Version: 29.0a1 Base Image: V1.2-device.cfg
Comment 5•10 years ago
|
||
Not sure how the status flags got reset, did not touch them at all when submitting the previous comment.
status-b2g-v1.3:
--- → unaffected
status-firefox29:
--- → affected
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → johu
Comment 6•10 years ago
|
||
IMO Gallery activity should support landscape mode as well as Gallery app so I prefer to fix this in gallery app.
Assignee | ||
Comment 7•10 years ago
|
||
add resize support to open activity.
Attachment #8362373 -
Flags: review?(dflanagan)
Comment 8•10 years ago
|
||
Comment on attachment 8362373 [details] [review] resize media frame when window is resized. r+, assuming you've tested carefully. Is there any other code that uses media_frame.js and does not handle resize events like this? Camera uses it, but has locked orientation so it wouldn't get resizes. It is a recent change that portrait mode apps like messages allow inline activities to rotate like this. Is that change going to stay or be reverted, I wonder. In either case, this patch should land. Thanks, John!
Attachment #8362373 -
Flags: review?(dflanagan) → review+
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to David Flanagan [:djf] from comment #8) > It is a recent change that portrait mode apps like messages allow inline > activities to rotate like this. Is that change going to stay or be reverted, > I wonder. I had discussed this with alive. I think that change will stay in our codebase.
Assignee | ||
Comment 10•10 years ago
|
||
merged to master: https://github.com/mozilla-b2g/gaia/commit/53672e4a7eeb0cf45d2a0e83563b33065f4bdbae There is a test case failed frequently and not related to this patch. So, I land the code to master.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
blocking-b2g: 1.4? → 1.4+
Comment 12•10 years ago
|
||
This bug is only visible on 1.3 after bug 963707 being uplifted. For more and lengthy discussion, see bug 979086.
blocking-b2g: 1.4+ → 1.3+
Comment 14•10 years ago
|
||
John, could you help? Thank you.
Flags: needinfo?(timdream) → needinfo?(johu)
Updated•10 years ago
|
Comment 16•10 years ago
|
||
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: [Testing completed]: [Risk to taking this patch] (and alternatives if risky): [String changes made]:
Attachment #8396133 -
Flags: approval-gaia-v1.3?(timdream)
Flags: needinfo?(shchen)
Updated•10 years ago
|
Attachment #8396133 -
Flags: approval-gaia-v1.3?(timdream) → approval-gaia-v1.3?(fabrice)
Comment 17•10 years ago
|
||
(In reply to Sherman Chen [:chens] from comment #16) > [Approval Request Comment] > [Bug caused by] (feature/regressing bug #): > [User impact] if declined: > [Testing completed]: > [Risk to taking this patch] (and alternatives if risky): > [String changes made]: Sherman, you did not fill this form.
Flags: needinfo?(shchen)
Comment 18•10 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #17) > (In reply to Sherman Chen [:chens] from comment #16) > Sherman, you did not fill this form. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Bug 979086 [User impact] if declined: The picture will not display in the middle of the screen in Landscape mode [Testing completed]: Manually tested [Risk to taking this patch] (and alternatives if risky): No [String changes made]: No
Flags: needinfo?(shchen)
Updated•10 years ago
|
Attachment #8396133 -
Flags: approval-gaia-v1.3?(fabrice) → approval-gaia-v1.3+
Comment 19•10 years ago
|
||
v1.3: https://github.com/mozilla-b2g/gaia/commit/7d52a880f7e2c04c9203dc8e6b77de00c05f256d
Target Milestone: --- → 1.4 S2 (28feb)
Updated•10 years ago
|
Comment 21•10 years ago
|
||
But in bug 989177 If the picture's name is long then the picture's name is not orderliness, this issue still not be fixed.
You need to log in
before you can comment on or make changes to this bug.
Description
•