960237 - Re-enable browser_dbg_break-on-dom-05.js

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

This test is disabled, but there's no note in browser.ini linking to a particular bug to re-enable it. Bug 942899 might be the cause, but it's not certain.

Comment 1

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/3fa4ad7d8e7c

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

It was apparently disabled in https://hg.mozilla.org/integration/fx-team/rev/8fee8dd350fd, and it wasn't part of the reviewed patch. Are you sure it wasn't just an inadvertent change?

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #2)
> It was apparently disabled in
> https://hg.mozilla.org/integration/fx-team/rev/8fee8dd350fd, and it wasn't
> part of the reviewed patch. Are you sure it wasn't just an inadvertent
> change?

I think it might have been accidentally disabled :/ I'll look into it.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v1

This was entirely my fault, sorry! I commented out a test because it was failing, fixed it, and then forgot to actually update the patch before landing.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8360928 [details] [diff] [review]
v1

Review of attachment 8360928 [details] [diff] [review]:
-----------------------------------------------------------------

No worries, you are the one who discovered and fixed it!

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/3d7a30c4601c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3fa4ad7d8e7c
https://hg.mozilla.org/mozilla-central/rev/3d7a30c4601c