960248 - [AccessFu] Label-embedded range widgets don't get keyboard events from label.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Since bug #915458, we land on a label with a nested control, instead of the control itself. The assumption is that activating the label will activate the control, which is true. But range widgets, take up/down arrow keys which are not redirected to the labelled control from the label. So we need to do that manually. Also, for non native ranges this would all go without saying.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Fix range adjustments when on a label.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8360626 [details] [diff] [review]
Fix range adjustments when on a label.

Review of attachment 8360626 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the inline change. Sorry for the long wait :).

::: accessible/src/jsat/content-script.js
@@ +342,5 @@
>  }
>  
>  function adjustRange(aMessage) {
>    function sendUpDownKey(aAccessible) {
> +    let acc = Utils.getEmbeddedControl(aAccessible);

I believe you need:
let acc = Utils.getEmbeddedControl(aAccessible) || aAccessible;
In case there's no label and there are no LABEL_FOR relations. Without it, I think, the swipe up/down will not work on plan input ranges.

@@ +346,5 @@
> +    let acc = Utils.getEmbeddedControl(aAccessible);
> +    if (acc.DOMNode) {
> +      let evt = content.document.createEvent('KeyboardEvent');
> +      let keycode = aMessage.json.direction == 'forward' ?
> +            content.KeyEvent.DOM_VK_DOWN : content.KeyEvent.DOM_VK_UP;

Nit: indentation.

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Yura Zenevich [:yzen] from comment #2)
> Comment on attachment 8360626 [details] [diff] [review]
> Fix range adjustments when on a label.
> 
> Review of attachment 8360626 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with the inline change. Sorry for the long wait :).
> 
> ::: accessible/src/jsat/content-script.js
> @@ +342,5 @@
> >  }
> >  
> >  function adjustRange(aMessage) {
> >    function sendUpDownKey(aAccessible) {
> > +    let acc = Utils.getEmbeddedControl(aAccessible);
> 
> I believe you need:
> let acc = Utils.getEmbeddedControl(aAccessible) || aAccessible;
> In case there's no label and there are no LABEL_FOR relations. Without it, I
> think, the swipe up/down will not work on plan input ranges.
> 

Good catch.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Fix range adjustments when on a label. r=yzen

Comment 5

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db9260e906fe

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/db9260e906fe