Streamline Editor API

RESOLVED FIXED in Firefox 29

Status

DevTools
Source Editor
P3
normal
RESOLVED FIXED
5 years ago
a month ago

People

(Reporter: anton, Assigned: anton)

Tracking

Trunk
Firefox 29
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Other components shouldn't know about gutters list and so on.
(Assignee)

Comment 1

5 years ago
Created attachment 8361463 [details] [diff] [review]
WIP 1

Refactored Editor API a little bit.

* Added option enableCodeFolding that other components can use instead of manually doing foldGutter = true and gutters = [ "CodeMirror-linenumbers",.. ]
* Removed isReadOnly method. It was used only once, in tests and can be replaced with a single line: editor.getOption("readOnly")
* Changed signature for jumpToLine, not sure why it was accepting CM instance as an argument.
* Removed showContextMenu method, it was used only once in the same file.
Attachment #8361463 - Flags: review?(mihai.sucan)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Summary: Streamline API for specifying gutters → Streamline Editor API
Comment on attachment 8361463 [details] [diff] [review]
WIP 1

Looks good.
Attachment #8361463 - Flags: review?(mihai.sucan) → review+
https://hg.mozilla.org/mozilla-central/rev/63ec016a22be
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.