Other components shouldn't know about gutters list and so on.
Created attachment 8361463 [details] [diff] [review] WIP 1 Refactored Editor API a little bit. * Added option enableCodeFolding that other components can use instead of manually doing foldGutter = true and gutters = [ "CodeMirror-linenumbers",.. ] * Removed isReadOnly method. It was used only once, in tests and can be replaced with a single line: editor.getOption("readOnly") * Changed signature for jumpToLine, not sure why it was accepting CM instance as an argument. * Removed showContextMenu method, it was used only once in the same file.
Attachment #8361463 - Flags: review?(mihai.sucan)
Status: NEW → ASSIGNED
Summary: Streamline API for specifying gutters → Streamline Editor API
Comment on attachment 8361463 [details] [diff] [review] WIP 1 Looks good.
Attachment #8361463 - Flags: review?(mihai.sucan) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.