960339 - Add a file picker to image uploads

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Brett Gaylor [:brett]]

In addition to drag and drop, can we add a file picker option and the text "Upload an image from your computer"?

Gerv reported in #955611 that users were not finding this option

Comment 1

[Gervase Markham [:gerv]]

Places like imgur seem to have standardized on a big drop target, with text like:

"Drag and drop and image here, or click to upload"

and when you click, the filepicker appears and activates itself. When you choose the file, the form auto-submits and the file is uploaded.

Gerv

Comment 2

[Scott [:thecount] Downe]

Agreed.

Comment 3

[Scott [:thecount] Downe]

Also wondering if half the problem was that the image drop location lived inside the image editor, which means an image is already added. Not very helpful for the first time you want to add an image.

I'm hesitant to add more to the media gallery, but doesn't that seem like the most logical place?

I'm going to be doing a bit of user testing soon, so I'll add image uploading to it.

I do like the click to uload part too, that's a nice addition.

Comment 4

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/502

Comment 5

[Ali Al Dallal [:alicoding]]

Comment on attachment 8390609 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/502

Some question in the PR.

Comment 6

[Ali Al Dallal [:alicoding]]

Comment on attachment 8390609 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/502

Wonderful!

Comment 7

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/15d9c1a689577f8dadeb62e55646759a2ee6c42f