96039 - Use of uninitialized value warning in process_bug.cgi

Status: RESOLVED WORKSFORME

(Bugzilla :: Administration, task, P2)

Description

[Rémi Perrot]

A Debian user report this bug (#108731) on the Debian bugzilla package
(http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=108731&repeatmerged=yes).

Comment 1

[Rémi Perrot]

Attachment: Retro port of a patch submited to Debian by Kestutis Kupciunas

Comment 2

[Matthew Tuck [:CodeMachine]]

Moving to new Bugzilla product ...

This is probably a duplicate of other reports, we'll need to clean up all the
uninitialised errors bug (there's currently 4).

Comment 3

[Gervase Markham [:gerv]]

I can't reproduce the error this patch claims to solve; and, if we do want to do
this, we should just do:

if ( $::COOKIE{'BUGLIST'} && $::FORM{'id'} ) {

which covers the undefined and the "" cases for both variables.

Gerv

Comment 4

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 5

[Chris Strahorn]

The warning for $::COOKIE{'BUGLIST'} being uninitialized is reproducable when 
you have no cookies for the bugzilla server, directly open an issue (e.g click 
on the link in an email from bugzilla), and make a change to the issue.  The 
page you get back after logging in has the warning at the top of the page, 
prior to the Content-Type: text/html header causing the context to be displayed 
as text/plain. 

Detailed steps:
Clear cookies for the bugzilla server (don't visit the site for a while, delete 
the cookie file if you're using IE, etc)
Look at an issue w/o searching, e.g. navigate to 
http://bugzilla.mozilla.org/show_bug.cgi?id=96039
Enter any update to the issue
Press the submit button
Login screen is displayed
Enter login and password
Press Login
Error is displayed at the top of the page returned

Comment 6

[Jouni Heikniemi]

Checking against the current codebase, I can't reproduce this and there is a fix
like Gerv's comment 3 in the code.

Marking WORKSFORME.

Comment 7

[Dave Miller [:justdave]]

clearing target in DUPLICATE/WORKSFORME/INVALID/WONTFIX bugs so they'll show up
as untriaged if they get reopened.