Multiple access keys used in preferences dialog for sq locale

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: whimboo, Assigned: besnik)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-l10n])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 8360957 [details]
screenshots.zip

Our Mozmill l10n tests have been shown that there are some access keys which are used multiple times in the same scope. The full list of those keys you can find here:

http://mozmill-daily.blargon7.com/#/l10n/report/50df0bef5c9d0b802925c134be2c27ec

Details:

 accessKey: "k" found in: value: Kur niset Aurora-i:, radio#alwaysAsk
accessKey: "m" found in: checkbox#warnCloseMultiple, checkbox#restoreOnDemand
accessKey: "n" found in: button[label=Ndihmë], label[control=sans-serif][accesskey=n]
accessKey: "s" found in: label[control=selectLangs][accesskey=S], label[control=serif][accesskey=S]
accessKey: "n" found in: button[label=Ndihmë], radio#dntnotrack
accessKey: "n" found in: button[label=Ndihmë], radio#dntnotrack
accessKey: "c" found in: checkbox#acceptCookies, label#acceptThirdPartyLabel
accessKey: "n" found in: button[label=Ndihmë], radio#dntnotrack
accessKey: "p" found in: checkbox#privateBrowsingAutoStart, button#cookieExceptions
accessKey: "c" found in: checkbox#acceptCookies, label#acceptThirdPartyLabel
accessKey: "n" found in: button[label=Ndihmë], radio#dntnotrack
accessKey: "p" found in: checkbox#privateBrowsingAutoStart, button#cookieExceptions
accessKey: "k" found in: checkbox#searchStartTyping, button#setDefaultButton
accessKey: "n" found in: button[label=Ndihmë], button#clearOfflineAppCacheButton
accessKey: "m" found in: radio[label=Mos kontrollo kurrë për përditësime (e pakëshillueshme: rrezik sigurie)], checkbox#enableSearchUpdate 

Attached you can find the screenshots of the reported failures.
(Assignee)

Comment 1

5 years ago
Thank you Henrik for this great help!

http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/file/b151e8cd9e76  should have fixed all them. I hope I haven't introduced new ones.

Before I close this bug, I'd like to ask you if I could have similar reports for all products under mozilla-aurora/sq

Also, is it possible to have zip of screenshots for all shortcuts, not just for the duplicated ones. It's much easier to check them from a screenshot.

If there's a way to run the checks and produce screenshots by myself I'd be grateful to be instructed.
Status: NEW → ASSIGNED
(Reporter)

Comment 2

5 years ago
(In reply to Besnik Bleta from comment #1)
> Thank you Henrik for this great help!
> 
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/file/b151e8cd9e76 
> should have fixed all them. I hope I haven't introduced new ones.

At http://mozmill-daily.blargon7.com/#/l10n I can see same failing tests like:
http://mozmill-daily.blargon7.com/#/l10n/report/50df0bef5c9d0b802925c134be45277b

accessKey: "n" found in: button[label=Ndihmë], value: Kur niset Aurora-i: 

None other are present anymore. Looks like we are close.

> Before I close this bug, I'd like to ask you if I could have similar reports
> for all products under mozilla-aurora/sq

We are building up those kind of tests. But sadly we don't have resources at the moment to implement that many new tests. Therefore any help would be appreciated.

> Also, is it possible to have zip of screenshots for all shortcuts, not just
> for the duplicated ones. It's much easier to check them from a screenshot.

No. We create those screenshots only for detected duplicates. If you want to run those tests locally, you could tweak the tests to create screenshots from everything.

> If there's a way to run the checks and produce screenshots by myself I'd be
> grateful to be instructed.

Yes, you can. Please have a look at the MDN page I just have created:
https://developer.mozilla.org/en-US/docs/Mozmill_Tests/L10n_tests
(Assignee)

Comment 3

5 years ago
Thank you! I'll put your tests on my routine.
I just commited a fix for the last one. Feel free to close the bug if your dashboard report no more errors fpr sq.
(Reporter)

Comment 4

5 years ago
Looks perfect. Thanks Besnik.

In case you are interested in this kind of automation and want to know more, feel free to join us on IRC in the #automation channel.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.