Closed
Bug 960493
Opened 10 years ago
Closed 10 years ago
SelectionEvent doesn't call MOZ_CRASH for IPC
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
644 bytes,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
SelectionEvent uses via IPC, but TextEvents.h doesn't allow IPC. When using IPC, SelectionEvent is craeted by default constructor. But it calls MOZ_CRASH.
Assignee | ||
Comment 1•10 years ago
|
||
PBrowser uses WidgetSelectionEvent by SelectionEvent(), so IPDL generates the following for send/recv this object. So this constructor dones't call MOZ_CRASH. (ipc/ipdl/PBrowserChild.cpp) ... void* __iter = 0; WidgetSelectionEvent event; if ((!(Read((&(event)), (&(__msg)), (&(__iter)))))) { FatalError("Error deserializing 'WidgetSelectionEvent'"); return MsgValueError; } ...
Attachment #8361029 -
Flags: review?(roc)
Attachment #8361029 -
Flags: review?(roc) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0dbee34a731d
Assignee | ||
Updated•10 years ago
|
Blocks: e10s-ime-tsf
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0dbee34a731d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•