Closed Bug 960493 Opened 6 years ago Closed 6 years ago

SelectionEvent doesn't call MOZ_CRASH for IPC

Categories

(Core :: DOM: Events, defect)

x86
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

SelectionEvent uses via IPC, but TextEvents.h doesn't allow IPC.

When using IPC, SelectionEvent is craeted by default constructor.  But it calls MOZ_CRASH.
PBrowser uses WidgetSelectionEvent by SelectionEvent(), so IPDL generates the following for send/recv this object.  So this constructor dones't call MOZ_CRASH.

(ipc/ipdl/PBrowserChild.cpp)
...
            void* __iter = 0;
            WidgetSelectionEvent event;

            if ((!(Read((&(event)), (&(__msg)), (&(__iter)))))) {
                FatalError("Error deserializing 'WidgetSelectionEvent'");
                return MsgValueError;
            }
...
Attachment #8361029 - Flags: review?(roc)
Blocks: e10s-ime-tsf
https://hg.mozilla.org/mozilla-central/rev/0dbee34a731d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.