Closed
Bug 960528
Opened 10 years ago
Closed 10 years ago
Remove the dashed border around items in the downloads library
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: phlsa, Assigned: dhenein)
Details
(Whiteboard: [good first verify])
Attachments
(2 files, 1 obsolete file)
280.14 KB,
image/png
|
Details | |
918 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
The dashed border around list entries appears to be legacy from Windows and shouldn't be shown on OS X. I'm not sure if there are other occurrences of this style. If so, the border should be removed there too.
Assignee | ||
Comment 1•10 years ago
|
||
This patch removes the dotted outline on focus state for richlistbox elements.
Attachment #8361079 -
Flags: review?(MattN+bmo)
Comment 2•10 years ago
|
||
Comment on attachment 8361079 [details] [diff] [review] remove-dotted-outlines.patch The focus indicator gives useful feedback for keyboard accessibility, so we can't just remove it without a replacement. That's at least the case on Windows. The keyboard accessibility story on Mac is less clear to me.
Attachment #8361079 -
Flags: review?(MattN+bmo) → review-
Updated•10 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
Version: 29 Branch → Trunk
Reporter | ||
Comment 3•10 years ago
|
||
At least in the downloads panel, the entire blue highlight is moving when navigating with the keyboard (same on Mac and Windows, though this bug is specifically about the Mac), So I see no problem there. I haven't found any other places in Firefox where we use this styling yet. This bug is only about removing the dotted border, not the blue highlight.
Assignee | ||
Comment 4•10 years ago
|
||
We still have a background and text color change/highlight to indicate the focused element, the dashed outline was in addition (and thus deemed superfluous), which UX deemed enough to warrant it's removal. Requesting reconsideration of review.
Assignee | ||
Updated•10 years ago
|
Attachment #8361079 -
Flags: review- → review?(dao)
Comment 5•10 years ago
|
||
(In reply to Philipp Sackl [:phlsa] from comment #3) > At least in the downloads panel, the entire blue highlight is moving when > navigating with the keyboard (same on Mac and Windows, though this bug is > specifically about the Mac), So I see no problem there. You can select multiple items there, each of which will be highlighted, but only one will be focused and get the focus outline. In lists that don't allow selecting multiple items, there's no focus outline.
Comment 6•10 years ago
|
||
Comment on attachment 8361079 [details] [diff] [review] remove-dotted-outlines.patch see comment 5
Attachment #8361079 -
Flags: review?(dao) → review-
Reporter | ||
Comment 7•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #5) > (In reply to Philipp Sackl [:phlsa] from comment #3) > > At least in the downloads panel, the entire blue highlight is moving when > > navigating with the keyboard (same on Mac and Windows, though this bug is > > specifically about the Mac), So I see no problem there. > > You can select multiple items there, each of which will be highlighted, but > only one will be focused and get the focus outline. In lists that don't > allow selecting multiple items, there's no focus outline. As discussed, I took a closer look at the native OS X behavior and the accessibility settings. Even with advanced keyboard navigation enabled, OS X doesn't show any additional indicators for the most recent item. So the consistent thing would be to remove the border on Mac.
Comment 8•10 years ago
|
||
(In reply to Philipp Sackl [:phlsa] from comment #7) > So the consistent thing would be to remove the border on Mac. Fine by me. Note that the currently attached patch affects Windows too.
Assignee | ||
Comment 9•10 years ago
|
||
Removed Windows from the patch.
Attachment #8361079 -
Attachment is obsolete: true
Attachment #8361655 -
Flags: review?(dao)
Comment 10•10 years ago
|
||
Comment on attachment 8361655 [details] [diff] [review] remove-dotted-outlines.patch v2 >Bug 960528 - Removed dotted outline from richlistbox as used in the Places modal -> Downloads list. r=mattn actually r=dao
Attachment #8361655 -
Flags: review?(dao) → review+
Updated•10 years ago
|
Assignee: nobody → dhenein
Reporter | ||
Comment 11•10 years ago
|
||
Looks like this just needs someone to push it to m-c now. Dão, could you do this?
Flags: needinfo?(dao)
Comment 12•10 years ago
|
||
I can do it, or anybody else can if they get to it before I do.
Flags: needinfo?(dao)
Keywords: checkin-needed
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/551290ba9d3b
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•