960530 - Improve the app icon searching in launch tests

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I introduced an issue when removing the additional B2G restart in bug 960200 when the application being launched is not in the dock. This is because we go to the next page of apps without checking if we're on the first page, so subsequent test runs fail to find the app icon. We should fix this by making sure we're on the correct page before we search for the icon.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Improve the app icon searching in launch tests. v1.0

I also noticed that this wouldn't work for any app icons present on the last page. This patch has been tested with apps in the dock, and each page of the homescreen (excluding the everything.me page).

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8361059 [details] [diff] [review]
Improve the app icon searching in launch tests. v1.0

Review of attachment 8361059 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

::: src/eideticker/eideticker/test.py
@@ +526,4 @@
>  
>          from gaiatest.apps.homescreen.app import Homescreen
>          homescreen = Homescreen(self.device.marionette)
> +        self.device.gaiaApps.switch_to_displayed_app()  # switches to homescreen

Did you mean to change this? Looks like just an added space.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to William Lachance (:wlach) from comment #2)
> Comment on attachment 8361059 [details] [diff] [review]
> Improve the app icon searching in launch tests. v1.0
> 
> Review of attachment 8361059 [details] [diff] [review]:
> -----------------------------------------------------------------
> ::: src/eideticker/eideticker/test.py
> @@ +526,4 @@
> >  
> >          from gaiatest.apps.homescreen.app import Homescreen
> >          homescreen = Homescreen(self.device.marionette)
> > +        self.device.gaiaApps.switch_to_displayed_app()  # switches to homescreen
> 
> Did you mean to change this? Looks like just an added space.

Yep, this is to comply with PEP 8. See http://www.python.org/dev/peps/pep-0008/#inline-comments

I use a pre-commit hook to check my code for PEP 8 compliance, and may submit a patch to fix all the Python code to comply with PEP 8.

Landed in:
https://github.com/mozilla/eideticker/commit/db322b71a80c248d49c9eba4cb4205e67d62cdd9