960534 - Market place DEV installation problem

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect)

Description

[rafael.medola]

Region code: Hanger
Device: Unagi
Connection: 3G/WiFi
Phone number/MSISDN: [phone]
Carrier: Telenor
Last 4 digits CC: -
Test App used: -

steps to reproduce:

1- Install the certs for marketplace dev on your Unagi phone;
2- Go to https://marketplace-dev.allizom.org/app/marketplace/ > install the dev app;
3- Try to open it.

expected behavior:

The marketplace Dev runs without a problem.

observed behavior:

The error: "Dev is not loading properly" is displayed.

Comment 1

[rafael.medola]

Attachment: logcat grep

Comment 2

[Stuart Colville [:muffinresearch]]

I can repro this on unagi too. 

After installing the certs I found that the dev app didn't install correctly and I have the following in my adb logcat output:

https://pastebin.mozilla.org/4028669

I see a "Dev Download stopped" message.

Then if you go to the homescreen there's  a "Dev" icon without a proper marketplace logo. Clicking that it says "Restart Download Do you want to download Dev". Which I've done. Which then gives me an app that shows the "Dev is not loading properly message" as per the STR.

Comment 3

[rafael.medola]

Attachment: screen

Comment 4

[krupa raj[:krupa]]

I don't think this is a certs problem since other packaged apps can be installed from dev without any issues.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

CC'ing Jason/Fabrice to help decode this error: https://pastebin.mozilla.org/4028669

Comment 6

[Jason Smith [:jsmith]]

This error is seen in the logcat:

DUPLICATE_ORIGIN

Comes from http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#3246

That means you are trying to install two privileged apps that have the same packaged app origin.

Can someone run 'adb shell cat /data/local/webapps/webapps.json' & attach the output to the bug?

Comment 7

[Iulian Timis]

Attachment: shell.txt

I have tried to install the MP-dev app on FF OS 1.4 (Inari) and got the following error "Marketplace install failed".
Ran the command and attached the output.

Comment 8

[krupa raj[:krupa]]

I also see 
01-29 14:31:30.765 E/GeckoConsole(  109): Content JS INFO at app://system.gaiamobile.org/js/app_install_manager.js:354 in ai_handleDownloadError: downloadError event, error code is INVALID_PACKAGE
01-29 14:31:30.855 E/GeckoConsole(  384): Content JS WARN at app://homescreen.gaiamobile.org/gaia_build_defer_index.js:179 in isHiddenApp: Unexpected role when checking hidden app: undefined

Comment 9

[Jason Smith [:jsmith]]

(In reply to krupa raj[:krupa] from comment #8)
> I also see 
> 01-29 14:31:30.765 E/GeckoConsole(  109): Content JS INFO at
> app://system.gaiamobile.org/js/app_install_manager.js:354 in
> ai_handleDownloadError: downloadError event, error code is INVALID_PACKAGE
> 01-29 14:31:30.855 E/GeckoConsole(  384): Content JS WARN at
> app://homescreen.gaiamobile.org/gaia_build_defer_index.js:179 in
> isHiddenApp: Unexpected role when checking hidden app: undefined

That error implies is a catch all error for when we fail to read the package.

Comment 10

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #9)
> (In reply to krupa raj[:krupa] from comment #8)
> > I also see 
> > 01-29 14:31:30.765 E/GeckoConsole(  109): Content JS INFO at
> > app://system.gaiamobile.org/js/app_install_manager.js:354 in
> > ai_handleDownloadError: downloadError event, error code is INVALID_PACKAGE
> > 01-29 14:31:30.855 E/GeckoConsole(  384): Content JS WARN at
> > app://homescreen.gaiamobile.org/gaia_build_defer_index.js:179 in
> > isHiddenApp: Unexpected role when checking hidden app: undefined
> 
> That error implies is a catch all error for when we fail to read the package.

Found out this is tested on 1.4. There's fundamental problems on that branch right now - see bug 949094 as an example.

Comment 11

[Jason Smith [:jsmith]]

Figured out the problem here. The marketplace dev app has the same origin as the marketplace prod app, so when we try to install the marketplace dev app (origin = app://marketplace.firefox.com currently), we'll get a DUPLICATE_ORIGIN error, as marketplace prod is already installed (origin = app://marketplace.firefox.com). We can fix this bug by ensuring that marketplace dev origin is used in the origin manifest property for the marketplace dev app.

Comment 12

[Jason Smith [:jsmith]]

Also - the issue seen on 1.4 is different than the 1.1 issue, so let's retest this after we fix the DUPLICATE_ORIGIN bug here.

Comment 13

[Christopher Van Wiemeersch [:cvan]]

Thanks, Jason. Good eye.

Fixed our -dev and stage packages.

Comment 14

[Christopher Van Wiemeersch [:cvan]]

There was a bug in my build script :(
Fixed: https://github.com/mozilla/fireplace/commit/a45b0ca