960582 - use nsIFile for pathname construction when dumping mochitest memory files

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use nsIFile for pathname construction when dumping mochitest memory files

Prior to this patch, we used forward slashes for pathname concatenation.  We
shouldn't do that, especially because the filename manipulation functions we
use inside XPCOM complain about forward slashes in Windows pathnames.

Instead, use nsIFile to concatenate pathnames, so the correct kind of slash
is used in all cases.  I love cross-platform code, don't you?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8361128 [details] [diff] [review]
use nsIFile for pathname construction when dumping mochitest memory files

Review of attachment 8361128 [details] [diff] [review]:
-----------------------------------------------------------------

nice- I think there might be other areas unrelated to memorystats that could use similar love.

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca89ba165731

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ca89ba165731