DMD build needs to be more consistent about where shared library goes

RESOLVED WORKSFORME

Status

()

Core
DMD
RESOLVED WORKSFORME
4 years ago
4 years ago

People

(Reporter: froydnj, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
While attempting to understand how to get DMD to work on windows, I discovered that something in the build system is inconsistent about where libdmd.so/dmd.dll goes.  On a Linux --enable-dmd build, I get:

dist/lib/libdmd.so (symlink to memory/replace/dmd/libdmd.so)
dist/bin/libdmd.so (likewise)

But on a Windows --enable-dmd build, I get:

dist/lib/dmd.lib
dist/bin/dmd.dll

This matters because mach's mochitest support for running with DMD assumes that the DMD shared library can be found in dist/lib.  And it could when that support was written.  I assume the location changed when DMD actually started getting packaged in --enable-dmd builds.  That's fine, we can update the mochitest support.

But I don't see why Linux builds would continue to have a shared library link in dist/lib/.  Mike, do you have insight here?
dist/lib is used to find libs to link (-Ldist/lib). That's why it contains .so files on linux and .lib files on windows.
mach's mochitest support should be using the lib in dist/bin, not dist/lib.
(Reporter)

Comment 2

4 years ago
(In reply to Mike Hommey [:glandium] from comment #1)
> dist/lib is used to find libs to link (-Ldist/lib). That's why it contains
> .so files on linux and .lib files on windows.
> mach's mochitest support should be using the lib in dist/bin, not dist/lib.

It is now, post- bug 960612.  So things are functionally normally, then?
Flags: needinfo?(mh+mozilla)
It should.
Flags: needinfo?(mh+mozilla)
(Reporter)

Comment 4

4 years ago
Like the bug status says, then.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.