960611 - [Camera] Create mechanism to save/load user settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, enhancement)

Description

[Diego Marcos [:dmarcos]]

Some use cases require to save certain settings when closing the camera. e.g: Flash state is persisted between camera launches.

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 2

[Diego Marcos [:dmarcos]]

Attachment: New Pull request adding new Camera API changes (bug 958200)

Comment 3

[Diego Marcos [:dmarcos]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/3d01dbcfe42d6f57c794855b8c4bcc462e4e38d1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Reverted for Gaia unit test perma-fail on TBPL.
https://github.com/mozilla-b2g/gaia/commit/e86a1d8a35d68c00267edb087b230d82115dac8c

https://tbpl.mozilla.org/php/getParsedLog.php?id=34669659&tree=B2g-Inbound

gaia-unit-tests TEST-UNEXPECTED-FAIL | camera/test/unit/lib/sounds_test.js | Sounds Sounds#createAudio() Should set the mozAudioChannel type | expected false to be truthy
gaia-unit-tests TEST-UNEXPECTED-FAIL | camera/test/unit/controllers/hud_test.js | controllers/hud "before each" hook | The constructor should be a function.
    TypeError: The constructor should be a function.

Comment 5

[Wilson Page [:wilsonpage]]

Ran all unit-tests locally on 'master' branch and all seem to be passing. Pointing to TBPL env differences.

Comment 6

[Wilson Page [:wilsonpage]]

Submitted a fix for camera/test/unit/controllers/hud_test.js

https://github.com/dmarcos/gaia/pull/32

Can't recreate the audio one at the moment.

Comment 7

[Wilson Page [:wilsonpage]]

I have no idea why the audio test would be failing. It is an old test that has been around for a long time. The hud test failure was understandable.

I suggest we try to land again, but will leave this decision to dmarcos.

Comment 8

[Diego Marcos [:dmarcos]]

Landed in:

https://github.com/mozilla-b2g/gaia/commit/4743cc22af8e6e4473913982eb9ef148b3d11999