Consistently mark IPDL methods as MOZ_OVERRIDE

RESOLVED FIXED in mozilla29

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bent.mozilla, Assigned: jaas)

Tracking

Trunk
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(3 attachments, 1 obsolete attachment)

All IPDL methods are virtual and should be marked with MOZ_OVERRIDE to ensure that they actually override the IPDL methods.
Assignee

Updated

5 years ago
Assignee: nobody → joshmoz
Assignee

Comment 1

5 years ago
Posted patch 1st batch (obsolete) — Splinter Review
Will run through try server and verify that everything works.
Attachment #8361486 - Flags: review?(bent.mozilla)
Assignee

Comment 2

5 years ago
bitrots fast!

https://tbpl.mozilla.org/?tree=Try&rev=f1c1e8cce0e2
Attachment #8361486 - Attachment is obsolete: true
Attachment #8361486 - Flags: review?(bent.mozilla)
Attachment #8361491 - Flags: review?(bent.mozilla)
Comment on attachment 8361491 [details] [diff] [review]
1st batch (v2)

Review of attachment 8361491 [details] [diff] [review]:
-----------------------------------------------------------------

Woohoo!
Attachment #8361491 - Flags: review?(bent.mozilla) → review+
Assignee

Comment 5

5 years ago
Posted patch 2nd batchSplinter Review
Covers network, uriloader, gfx, js... Not planning to ask for module-specific reviews, let me know if you disagree.
Attachment #8361820 - Flags: review?(bent.mozilla)
Comment on attachment 8361820 [details] [diff] [review]
2nd batch

Review of attachment 8361820 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8361820 - Flags: review?(bent.mozilla) → review+
(In reply to Josh Aas (Mozilla Corporation) from comment #5)
> Not planning to ask for
> module-specific reviews, let me know if you disagree.

No, as long as this compiles it doesn't need review from others. I'm tempted to blanket rs+ any additions of MOZ_OVERRIDE anywhere in the tree.
Assignee

Comment 9

5 years ago
Pushed this patch that removes dead code I found while doing this:

http://hg.mozilla.org/integration/mozilla-inbound/rev/98a42a023afb
https://hg.mozilla.org/mozilla-central/rev/679616f29acc
https://hg.mozilla.org/mozilla-central/rev/9d2d2a2bea7f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.