Closed
Bug 960648
Opened 10 years ago
Closed 10 years ago
Consistently mark IPDL methods as MOZ_OVERRIDE
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bent.mozilla, Assigned: jaas)
Details
(Whiteboard: [qa-])
Attachments
(3 files, 1 obsolete file)
|
61.61 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
|
33.37 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
|
34.29 KB,
patch
|
Details | Diff | Splinter Review |
All IPDL methods are virtual and should be marked with MOZ_OVERRIDE to ensure that they actually override the IPDL methods.
Will run through try server and verify that everything works.
Attachment #8361486 -
Flags: review?(bent.mozilla)
bitrots fast! https://tbpl.mozilla.org/?tree=Try&rev=f1c1e8cce0e2
Attachment #8361486 -
Attachment is obsolete: true
Attachment #8361486 -
Flags: review?(bent.mozilla)
Attachment #8361491 -
Flags: review?(bent.mozilla)
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8361491 [details] [diff] [review] 1st batch (v2) Review of attachment 8361491 [details] [diff] [review]: ----------------------------------------------------------------- Woohoo!
Attachment #8361491 -
Flags: review?(bent.mozilla) → review+
Covers network, uriloader, gfx, js... Not planning to ask for module-specific reviews, let me know if you disagree.
Attachment #8361820 -
Flags: review?(bent.mozilla)
|
|
Reporter | |
Comment 6•10 years ago
|
||
Comment on attachment 8361820 [details] [diff] [review] 2nd batch Review of attachment 8361820 [details] [diff] [review]: ----------------------------------------------------------------- \o/
Attachment #8361820 -
Flags: review?(bent.mozilla) → review+
|
|
Reporter | |
Comment 7•10 years ago
|
||
(In reply to Josh Aas (Mozilla Corporation) from comment #5) > Not planning to ask for > module-specific reviews, let me know if you disagree. No, as long as this compiles it doesn't need review from others. I'm tempted to blanket rs+ any additions of MOZ_OVERRIDE anywhere in the tree.
Pushed this patch that removes dead code I found while doing this: http://hg.mozilla.org/integration/mozilla-inbound/rev/98a42a023afb
|
||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/679616f29acc https://hg.mozilla.org/mozilla-central/rev/9d2d2a2bea7f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
Assignee | |
Comment 11•10 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/f64e462a943c
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•