Closed Bug 960669 Opened 6 years ago Closed 6 years ago
Exiting the browser window should exit the Browser Toolbox
From more discussion, it seems this is due to the Browser Toolbox's process remaining alive after the toolbox is closed. This might be related to how the toolbox is closed (window X vs. toolbox X vs. quit).
Are you sure you are closing both processes? Does the second icon in the dock disappear along with the first? In my experience, killing the browser process will leave the browser toolbox process unaffected. I have to quit it directly with Cmd-Q. Or is this an enhancement request to have the browser process exit the spawned browser toolbox as well?
OS: Mac OS X → All
Hardware: x86 → All
I realized that I was not closing the toolbox, but killing the browser process only in the original issue. Now I've noticed that there are ways to close the toolbox process but not having it disappear from the dock (I believe I've been able to reproduce by quickly focusing back on the main browser window but that could just be voodoo). With this knowledge, I would love an enhancement that causes exiting the browser process to exit the spawned browser toolbox as well.
OK, agreed. Editing subject to clarify.
Severity: normal → enhancement
Summary: Browser Toolbox not opening after first load → Exiting the browser window should exit the Browser Toolbox
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8364552 - Flags: review?(past)
Comment on attachment 8364552 [details] [diff] [review] Close Browser Toolbox on browser shutdown Review of attachment 8364552 [details] [diff] [review]: ----------------------------------------------------------------- Works great! ::: browser/devtools/framework/ToolboxProcess.jsm @@ +155,5 @@ > } > }, > > /** > * Closes the remote debugger, removing the profile and killing the process. We are no longer removing the profile, would you mind updating the comment?
Attachment #8364552 - Flags: review?(past) → review+
Carrying over r+ from attachment 8364552 [details] [diff] [review]. (In reply to Panos Astithas [:past] from comment #6) > ::: browser/devtools/framework/ToolboxProcess.jsm > @@ +155,5 @@ > > } > > }, > > > > /** > > * Closes the remote debugger, removing the profile and killing the process. > > We are no longer removing the profile, would you mind updating the comment? Done!
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.