960720 - Change the client side Smart Collection wallpapers

Status: RESOLVED DUPLICATE of bug 1016221

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Patryk Adamczyk [:patryk] UX]

Change the wallpapers of the smart collections that ship on the device so they fit better with the direction of the OS.

Comment 1

[Amir Nissim (:amirn)]

We need new icons for every predefined Collection.
Who can provide the new assets?


As a reference, the current icons for 'Social' are here:
https://github.com/mozilla-b2g/gaia/tree/master/apps/homescreen/collections/social

List of predefined collections:
https://github.com/mozilla-b2g/gaia/tree/master/apps/homescreen/collections/

Comment 2

[Amir Nissim (:amirn)]

Question - 
What should happen when renaming a pre-installed (shipped on device) collection?
Should the bg change to reflect the new name or not?

Comment 3

[Amir Nissim (:amirn)]

We should also update the customization instructions on https://wiki.mozilla.org/B2G/MarketCustomizations#homescreens.json when this lands.

Comment 4

[Patryk Adamczyk [:patryk] UX]

Here are the smart collection graphics, we export them at 320x480 first, just want to make sure they work correctly first: https://mozilla.box.com/s/x97kfv029ivmwgklt724

Comment 5

[Amir Nissim (:amirn)]

Attachment: screenshot-homescreen.png

Comment 6

[Amir Nissim (:amirn)]

Attachment: screenshot-social.png

Comment 7

[Amir Nissim (:amirn)]

Thanks Patryk, added screenshots with the new graphics.

Comment 8

[Amir Nissim (:amirn)]

Regarding the different sizes for the assets, we discussed having different version per device height:
320x480.png, 480x800.png, 480x854.png, 540x960.png, 720x1280.png and 1080x1920.png

I am not sure the device height is available in build time (ni? yurenju)

in case it is not available, maybe a better solution will be to use the @2x, @2.5 versioning?

Comment 9

[Amir Nissim (:amirn)]

Attachment: 10-collections.png

updated PR to include all 10 default collections on homescreen (attached screenshot).

please note that if you |reset-gaia| with this branch, the new icons will appear only after a collection updates, meaning - one of the first 3 apps have changed.

for the Social collection you will have to reorder the first 3 apps to trigger an update. for the rest of the collections it will be enough to open it (make sure device is online so web apps can load and trigger the update).

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

Notice, the apps that appear in the Collection icons, in the screenshot attached, are local (Israel related).
When YOU update your device, it'll show apps that are relevant to YOUR location.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Amir, I thought I replied this bug but seems not, sorry.

the resolution information is not available on build time, so yes, using filename like @2x.jpg will be better than using resolution.

Comment 12

[Amir Nissim (:amirn)]

Attachment: PR

Comment 13

[Amir Nissim (:amirn)]

Attachment: All Collections with new icons

Comment 14

[Amir Nissim (:amirn)]

Comment on attachment 8432220 [details]
PR

https://github.com/mozilla-b2g/gaia/pull/18123

Comment 15

[Amir Nissim (:amirn)]

Attachment: PR

Comment 16

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/c3fe464

Comment 17

[Amir Nissim (:amirn)]

(In reply to Amir Nissim (Everything.me) from comment #16)
> landed: https://github.com/mozilla-b2g/gaia/commit/c3fe464

https://github.com/mozilla-b2g/gaia/commit/c3fe464726d18c0e5318bcbd8ed74cf2787875cf

Comment 18

[Amir Nissim (:amirn)]

Backed out:

commit: 2680cf4fc70c59cf801aab8283c0b3178175e3cf
Revert "Bug 960720 - Change the client side Smart Collection wallpapers [r=ranbena]"
This reverts commit 13c94ca.

Comment 19

[Amir Nissim (:amirn)]

patch to big and blocks hamachi builds - bug 1019321
not sure how to handle this

Comment 20

[Jason Smith [:jsmith]]

(In reply to Amir Nissim (Everything.me) from comment #19)
> patch to big and blocks hamachi builds - bug 1019321
> not sure how to handle this

Let me ask UX.

UX - The file changes being requested here are too big in size. Can you figure out a mitigation plan here?

Comment 21

[Stephany Wilkes]

Clearing the ni? for UX since this is being dealt with at a broader scale.

Comment 22

[Cristian Rodriguez (:crdlc)]

When you decide if this is migrated to @1.5, etc.. please let me know for bug 1020134, thanks

Comment 23

[Kevin Grandon :kgrandon]

In bug 1030440 Jacqueline has defined the three collections that should ship with the device as Social, Games, and Music. Because the full set is too large, one option might be to build with only these three, and have the rest come from the server. The problem with this is that I'm not sure if the suggestions list would be able to determine the difference between the defaults which we store locally, and results from the server. We don't want to remove a default collection, then re-add it to see a different icon for example. Potentially serving all background assets from a CDN might be the best option here. 

Also we should definitely use .png, @1.5x, @2x, etc extensions because that's how we ship the proper image to the device - it would probably help here.

Comment 24

[Amir Nissim (:amirn)]

Implemented for vertical homescreen