960744 - Intermittent test_calendar_new_event_appears_on_all_calendar_views.py test_calendar_new_event_appears_on_all_calendar_views.TestCalendar.test_that_new_event_appears_on_all_calendar_views | NoSuchElementException: Unable to locate element ...

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=33116811&tree=Mozilla-Inbound

b2g_ubuntu64_vm mozilla-inbound opt test gaia-ui-test on 2014-01-16 10:51:34 PST for push 544bdb194485
slave: tst-linux64-spot-391

11:00:17     INFO -  test_that_new_event_appears_on_all_calendar_views (test_calendar_new_event_appears_on_all_calendar_views.TestCalendar) ... ERROR
11:00:17     INFO -  ======================================================================
11:00:17     INFO -  ERROR: None
11:00:17     INFO -  ----------------------------------------------------------------------
11:00:17     INFO -  Traceback (most recent call last):
11:00:17     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 143, in run
11:00:17     INFO -      testMethod()
11:00:17     INFO -    File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/calendar/test_calendar_new_event_appears_on_all_calendar_views.py", line 37, in test_that_new_event_appears_on_all_calendar_views
11:00:17     INFO -      self.assertIn(event_title, calendar.displayed_events_in_month_view(event_start_date_time))
11:00:17     INFO -    File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/apps/calendar/app.py", line 55, in displayed_events_in_month_view
11:00:17     INFO -      return self.marionette.find_element(*self._get_events_locator_in_month_view(date_time)).text
11:00:17     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette.py", line 1116, in find_element
11:00:17     INFO -      response = self._send_message('findElement', 'value', **kwargs)
11:00:17     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette.py", line 593, in _send_message
11:00:17     INFO -      self._handle_error(response)
11:00:17     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette.py", line 614, in _handle_error
11:00:17    ERROR -      raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
11:00:17    ERROR -  TEST-UNEXPECTED-FAIL | test_calendar_new_event_appears_on_all_calendar_views.py test_calendar_new_event_appears_on_all_calendar_views.TestCalendar.test_that_new_event_appears_on_all_calendar_views | NoSuchElementException: Unable to locate element: #event-list section.hour-11 div.events
11:00:17     INFO -  ----------------------------------------------------------------------
11:00:17     INFO -  Ran 1 test in 28.996s
11:00:17  WARNING -  FAILED (errors=1)

Comment 1

[Zac C (:zac)]

Looking at the source code here for the failure report we can see that the test run, from creation of the event to clicking submit covered over a new hour.

This is because the expected condition is taken before the app is launched and the even added, which might take 10-15 seconds.

We need a fix on this.




  <section id="months-day-view" data-date="Thu Jan 16 2014 00:00:00 GMT-0800 (PST)" class="active">
    <section class="day-events" id="event-list"><section data-hour="12" class="hour hour-12  calendar-display calendar-id-local-first"><h4><span class="display-hour 12">12 PM</span></h4><div class="events"><section data-id="local-first-350e5538-5104-4b38-b41d-9c2e57dbd8eb-ef624ab4-acd8-4d16-a4d7-9a8300f9eef3" class="event calendar-id-local-first has-alarms calendar-display" style="height: 100%;"><div class="container calendar-id-local-first calendar-color"><h5>Event Title 11:59:58</h5><span class="details"><span class="location">Event Location 11:59:58</span></span></div></section></div></section></section>
  </section>

Comment 2

[Legacy TBPL/Treeherder Robot]

Tomcat
https://tbpl.mozilla.org/php/getParsedLog.php?id=33165821&tree=B2g-Inbound
b2g_macosx64 b2g-inbound opt test gaia-ui-test on 2014-01-17 04:47:27
revision: ea7cda529413
slave: talos-mtnlion-r5-026

raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_calendar_new_event_appears_on_all_calendar_views.py test_calendar_new_event_appears_on_all_calendar_views.TestCalendar.test_that_new_event_appears_on_all_calendar_views | NoSuchElementException: Unable to locate element: #event-list section.hour-5 div.events
Return code: 10

Comment 3

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=33205311&tree=B2g-Inbound
b2g_ubuntu64_vm b2g-inbound opt test gaia-ui-test on 2014-01-17 17:52:59
revision: 18dcbf73709d
slave: tst-linux64-spot-481

raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_calendar_new_event_appears_on_all_calendar_views.py test_calendar_new_event_appears_on_all_calendar_views.TestCalendar.test_that_new_event_appears_on_all_calendar_views | NoSuchElementException: Unable to locate element: #event-list section.hour-18 div.events
Return code: 10

Comment 4

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=33259694&tree=B2g-Inbound
b2g_ubuntu64_vm b2g-inbound opt test gaia-ui-test on 2014-01-19 18:47:28
revision: 123dc70cd915
slave: tst-linux64-spot-011

raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_calendar_new_event_appears_on_all_calendar_views.py test_calendar_new_event_appears_on_all_calendar_views.TestCalendar.test_that_new_event_appears_on_all_calendar_views | NoSuchElementException: Unable to locate element: #event-list section.hour-19 div.events
Return code: 10

Comment 5

[Florin Strugariu [:Bebe]]

Attachment: pull request

Comment 6

[Florin Strugariu [:Bebe]]

currently we expect that the new alarm time is current time + 1 hour and use locators based on that assumption. 
but if we run tests and the current time is x:59 then tit's a hight probability that the test will fail

Updated the test to use the actual event hour in the tests

Comment 7

[[:AndreiH]]

Comment on attachment 8363692 [details] [review]
pull request

Looks ok! Thanks @bebef1987 for looking into this!

Comment 8

[Viorela Ioia [:viorela]]

Comment on attachment 8363692 [details] [review]
pull request

I ran this test multiple times and got no failure. It seems that the intermittent problem was fixed by your patch.

Comment 9

[Zac C (:zac)]

(In reply to Viorela Ioia [:viorela] from comment #8)
> Comment on attachment 8363692 [details] [review]
> pull request
> 
> I ran this test multiple times and got no failure. It seems that the
> intermittent problem was fixed by your patch.

Did you test it at the right time of day?
Maybe even force the clock to be the time that might induce the failure?

Comment 10

[Zac C (:zac)]

Comment on attachment 8363692 [details] [review]
pull request

r-

Comment 11

[Zac C (:zac)]

Comment on attachment 8363692 [details] [review]
pull request

r+, Bebe can you squash it now?

Comment 12

[Florin Strugariu [:Bebe]]

zac done

Comment 13

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/427b1ed6fc7138588bc856f50715a9d176609c0b

Comment 14

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-b2g32_v2_0&job_id=94405
repository: mozilla-b2g32_v2_0
start_time: 2015-02-06T17:19:27
who: philringnalda[at]gmail[dot]com
machine: talos-mtnlion-r5-072
buildname: b2g_macosx64 mozilla-b2g32_v2_0 opt test gaia-ui-test
revision: c22797e5ee91

TEST-UNEXPECTED-FAIL | test_calendar_new_event_appears_on_all_calendar_views.py test_calendar_new_event_appears_on_all_calendar_views.TestCalendar.test_that_new_event_appears_on_all_calendar_views | NoSuchElementException: NoSuchElementException: Unable to locate element: //input[@data-l10n-id='event-location']
Return code: 10