Open Bug 960760 Opened 10 years ago Updated 8 months ago

Intermittent test_localStorageEnablePref.html | Expected SecurityError exception - got undefined, expected SecurityError

Categories

(Core :: DOM: Core & HTML, defect, P5)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Windows 7
Type:
defect

Tracking

()

People

(Reporter: RyanVM, Unassigned)

References

(
URL
)

Details

(Keywords: intermittent-failure, Whiteboard: [leave open]) 

https://tbpl.mozilla.org/php/getParsedLog.php?id=33038059&tree=Fx-Team

Windows 7 32-bit fx-team opt test mochitest-4 on 2014-01-15 08:06:22 PST for push 4ddb7a3d9cae
slave: t-w732-ix-089

08:10:12     INFO -  428 INFO TEST-START | /tests/dom/tests/mochitest/localstorage/test_localStorageEnablePref.html
08:10:12     INFO -  429 INFO TEST-PASS | /tests/dom/tests/mochitest/localstorage/test_localStorageEnablePref.html | Storage is present
08:10:12     INFO -  ************************************************************
08:10:12     INFO -  * Call to xpconnect wrapped JSObject produced this error:  *
08:10:12     INFO -  [Exception... "The operation is insecure."  code: "18" nsresult: "0x80530012 (SecurityError)"  location: "<unknown>"]
08:10:12     INFO -  ************************************************************
08:10:12     INFO -  430 INFO TEST-PASS | /tests/dom/tests/mochitest/localstorage/test_localStorageEnablePref.html | Storage is null
08:10:12     INFO -  431 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/localstorage/test_localStorageEnablePref.html | Expected SecurityError exception - got undefined, expected SecurityError
08:10:12     INFO -  432 INFO TEST-PASS | /tests/dom/tests/mochitest/localstorage/test_localStorageEnablePref.html | Exception SecurityError threw
08:10:12     INFO -  433 INFO TEST-PASS | /tests/dom/tests/mochitest/localstorage/test_localStorageEnablePref.html | Storage is present again
08:10:12     INFO -  434 INFO TEST-PASS | /tests/dom/tests/mochitest/localstorage/test_localStorageEnablePref.html | value - value can be set
08:10:12     INFO -  435 INFO TEST-INFO | MEMORY STAT vsize after test: 422031360
08:10:12     INFO -  436 INFO TEST-INFO | MEMORY STAT vsizeMaxContiguous after test: 628424704
08:10:12     INFO -  437 INFO TEST-INFO | MEMORY STAT residentFast after test: 147439616
08:10:12     INFO -  438 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 44604690
08:10:12     INFO -  439 INFO TEST-END | /tests/dom/tests/mochitest/localstorage/test_localStorageEnablePref.html | finished in 70ms
Martijn, any clue?
Flags: needinfo?(martijn.martijn)
Blocks: 913706
URL: http://mxr.mozilla.org/mozilla-centra...
Flags: needinfo?(martijn.martijn)
My guess is that this is the problem:
08:10:12     INFO -  * Call to xpconnect wrapped JSObject produced this error:  *
08:10:12     INFO -  [Exception... "The operation is insecure."  code: "18" nsresult: "0x80530012 (SecurityError)"  location: "<unknown>"]

Errors in the page themselves would give TEST-UNEXPECTED-FAIL, so this is an error in the chrome process.

I guess this is somehow causing the issue.
SpecialPowers.pushPrefEnv({"set": [["dom.storage.enabled", false]]}, test2);
But I have no idea how that exception can happen.
No, according to bug 932629, this error is happening because of trying to access localStorage while it is disabled in the prefs.
Ehsan, perhaps you can tell if there is something in the test that seems to trigger this race condition?
Flags: needinfo?(ehsan)
I pushed a debugging patch to tell us what exception is being thrown in checkException.  That should help us figure out where the exception is coming from.

http://hg.mozilla.org/integration/mozilla-inbound/rev/4804658f1be4

Also, I'm puzzled by the mention of chrome process in comment 3.  Is this not a single process browser?
Flags: needinfo?(ehsan)
Whiteboard: [leave open]
ok(true) doesn't work anymore... :(

Re-enable the debugging code: https://hg.mozilla.org/integration/mozilla-inbound/rev/cef723d9aa31
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #7)
> I pushed a debugging patch to tell us what exception is being thrown in
> checkException.  That should help us figure out where the exception is
> coming from.
> 
> http://hg.mozilla.org/integration/mozilla-inbound/rev/4804658f1be4
> 
> Also, I'm puzzled by the mention of chrome process in comment 3.  Is this
> not a single process browser?

Yes, sorry, that didn't make sense. I guess I was at that time all into mochitest e10s issues. 
Anyway, your debugging patch is helpful. The exception that is shown is this:
11:27:33     INFO -  211 INFO TEST-INFO | /tests/dom/tests/mochitest/localstorage/test_localStorageEnablePref.html | The exception which was thrown is: out of memory

No idea where that comes from.
Flags: needinfo?(ehsan)
That seems to suggest that we're running out of memory!
Flags: needinfo?(ehsan)
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #24)
> That seems to suggest that we're running out of memory!

Either that or someone forgot to set an exception when they returned false from JSAPI-related code. It's worth checking whether anyone called js_ReportOutOfMemory.
Bobby explained comment 25 for me on IRC: if there was a bug somewhere and somebody returned false for some other reason without setting an exception, we'll claim OOM when it was actually something else

There aren't really many mochitests running before the failing mochitests and the memory reports in the mochitests also don't really seem to indicate oom is going on, afaict.
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Priority: P3 → P5
Component: DOM → DOM: Core & HTML
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.