Closed
Bug 960774
Opened 10 years ago
Closed 10 years ago
Require ActorDestroy methods to be implemented for parent-side actors
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: bent.mozilla, Assigned: jaas)
References
Details
Attachments
(4 files, 3 obsolete files)
7.17 KB,
text/x-chdr
|
Details | |
14.65 KB,
text/x-c++src
|
Details | |
2.53 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
31.46 KB,
patch
|
Details | Diff | Splinter Review |
ActorDestroy is currently optional in both child and parent actor implementations. We almost always need to handle crashes in the parent so I think we should just bite the bullet and start requiring it to be implemented on the parent side.
Comment 1•10 years ago
|
||
Roughly the same as bug 610803 (parent-only is correct). Please dup whichever way makes more sense.
This makes ActorDestroy pure virtual on the parent side. Will attach another patch that adds ActorDestroy to everything missing it now.
This works on Linux. Will probably need a bit more work to catch everything on all platforms.
Fixes for B2G and Windows.
Attachment #8415763 -
Attachment is obsolete: true
Attachment #8415762 -
Flags: review?(bent.mozilla)
Attachment #8416032 -
Flags: review?(bent.mozilla)
Ben asked me to post example copies of files generated with my patch.
Fix bug in example code generation. Don't return false from void ActorDestroy method.
Attachment #8415762 -
Attachment is obsolete: true
Attachment #8415762 -
Flags: review?(bent.mozilla)
Attachment #8416286 -
Flags: review?(bent.mozilla)
Reporter | ||
Updated•10 years ago
|
Attachment #8416286 -
Flags: review?(bent.mozilla) → review+
Reporter | ||
Comment 9•10 years ago
|
||
Comment on attachment 8416032 [details] [diff] [review] add ActorDestroy where missing, v1.1 Review of attachment 8416032 [details] [diff] [review]: ----------------------------------------------------------------- This looks fine, though I'd change the comments in each of these to point to a *new* bug. We should just file one for each component to get people to investigate whether they need to do anything in these overrides.
Attachment #8416032 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Filed specific bugs for everything, this patch includes specific bug #s.
Attachment #8416032 -
Attachment is obsolete: true
Assignee | ||
Comment 11•10 years ago
|
||
pushed the patch adding ActorDestroy methods to all parent-side actors that don't have one https://hg.mozilla.org/integration/mozilla-inbound/rev/023830b8ad98
Assignee | ||
Comment 12•10 years ago
|
||
pushed patch requiring ActorDestroy on the parent side https://hg.mozilla.org/integration/mozilla-inbound/rev/2ece9c3282b7
https://hg.mozilla.org/mozilla-central/rev/023830b8ad98 https://hg.mozilla.org/mozilla-central/rev/2ece9c3282b7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•