960775 - Retire JS_WARN_UNUSED_RESULT in favor of MOZ_WARN_UNUSED_RESULT

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew McCreight [:mccr8]]

The JS_ version is enabled only with GCC, while the MOZ version is both GCC and Clang.  Or maybe it should just be replaced with MOZ_WARN?  It is only used in two places right now.

Comment 1

[Andrew McCreight [:mccr8]]

Also, the warnings from this don't seem to be fatal in js/src

Comment 2

[Andrew McCreight [:mccr8]]

(In reply to Andrew McCreight [:mccr8] from comment #1)
> Also, the warnings from this don't seem to be fatal in js/src

I guess warnings-as-errors is just an all-or-nothing thing?

Comment 3

[Jeff Walden [:Waldo]]

Replace it.  (We're just slow about switching to the other stuff for various reasons, inertia being perhaps the biggest.)

Newer compilers have -Werror=, which does get used for some things.  I don't know if it could be used for this or not.  I expect there to be many violations of the use-result requirement, tho.  :-(

Comment 4

[Andrew McCreight [:mccr8]]

Yeah, I'd really just want use-result violations to be fatal only when somebody opts in.  Anyways, hopefully the output is clean enough that somebody will notice eventually if something breaks.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Retire JS_WARN_UNUSED_RESULT in favor of MOZ_WARN_UNUSED_RESULT.

Comment 6

[Andrew McCreight [:mccr8]]

And of course right before I was going to land this somebody added a bunch of more uses of it. :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/73b036d72753

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/73b036d72753