Closed Bug 960854 Opened 7 years ago Closed 6 years ago

Port |Bug 920353 - pymake native commands can't easily use e.g. mozbuild modules| to c-c

Categories

(MailNews Core :: Build Config, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 29.0

People

(Reporter: ewong, Assigned: glandium)

Details

Attachments

(1 file, 1 obsolete file)

Building SeaMonkey (and I would guess Thunderbird), using Pymake, I'd
come across the following:

  Creating library fake.lib and object fake.exp
 
h:\mozprgs\devtools\config\rules.mk:917:0$ chmod +x suite.dll
h:\mozprgs\devtools\config\rules.mk:633:0$ nsinstall nsinstall -t -m 755 suite.dll ../../mozilla/dist/bin/components
h:\mozprgs\devtools\config\rules.mk:634:0$ : ../../mozilla/dist/bin/components/suite.dll
h:\mozprgs\devtools\config\rules.mk:636:0$ h:/mozprgs/devtools/objdir-sm/mozilla/_virtualenv/Scripts/python.exe -m mozbuild.action.buildlist ../../mozilla/dist/bin/chrome.manifest "manifest components/components.manifest"
h:\mozprgs\devtools\config\rules.mk:637:0$ h:/mozprgs/devtools/objdir-sm/mozilla/_virtualenv/Scripts/python.exe -m mozbuild.action.buildlist ../../mozilla/dist/bin/components/components.manifest "binary-component suite.dll"
make.py[5]: Leaving directory 'h:\mozprgs\devtools\objdir-sm\suite\build'
make.py[5]: Entering directory 'h:\mozprgs\devtools\objdir-sm\suite\app'
nsSuiteApp.cpp
h:\mozprgs\devtools\config\rules.mk:1005:0$ mozbuild.action.cl main  cl -FonsSuiteApp.obj -c   -DSEAMONKEY_ICO=\"../../mozilla/dist/branding/seamonkey.ico\" -DHTML_FILE_ICO=\"../../mozilla/dist/branding/html-file.ico\" -DAPP_VERSION="2.26a1" -DNO_BLOCKLIST_CRASHREPORTER  -DXPCOM_GLUE -DOSTYPE=\"WINNT6.0\" -DOSARCH=WINNT -DNO_NSPR_10_SUPPORT -Ih:/mozprgs/devtools/mozilla/toolkit/xre -Ih:/mozprgs/devtools/mozilla/xpcom/base -Ih:/mozprgs/devtools/mozilla/xpcom/build -I../../mozilla/build  -Ih:/mozprgs/devtools/suite/app -I. -I../../mozilla/dist/include -I../../mozilla/dist/include/nsprpub  -Ih:/mozprgs/devtools/objdir-sm/mozilla/dist/include/nspr -Ih:/mozprgs/devtools/objdir-sm/mozilla/dist/include/nss        -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -O1 -Oy -MD            -FI ../../mozilla/dist/include/mozilla-config.h -DMOZILLA_CLIENT h:/mozprgs/devtools/suite/app/nsSuiteApp.cpp
Error importing mozbuild.action.cl: No module named mozprocess.processhandler
h:\mozprgs\devtools\config\rules.mk:1005:0: command 'mozbuild.action.cl main  cl -FonsSuiteApp.obj -c   -DSEAMONKEY_ICO=\"../../mozilla/dist/branding/seamonkey.ico\" -DHTML_FILE_ICO=\"../../mozilla/dist/branding/html-file.ico\" -DAPP_VERSION="2.26a1" -DNO_BLOCKLIST_CRASHREPORTER  -DXPCOM_GLUE -DOSTYPE=\"WINNT6.0\" -DOSARCH=WINNT -DNO_NSPR_10_SUPPORT -Ih:/mozprgs/devtools/mozilla/toolkit/xre -Ih:/mozprgs/devtools/mozilla/xpcom/base -Ih:/mozprgs/devtools/mozilla/xpcom/build -I../../mozilla/build  -Ih:/mozprgs/devtools/suite/app -I. -I../../mozilla/dist/include -I../../mozilla/dist/include/nsprpub  -Ih:/mozprgs/devtools/objdir-sm/mozilla/dist/include/nspr -Ih:/mozprgs/devtools/objdir-sm/mozilla/dist/include/nss        -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -O1 -Oy -MD            -FI ../../mozilla/dist/include/mozilla-config.h -DMOZILLA_CLIENT h:/mozprgs/devtools/suite/app/nsSuiteApp.cpp' failed, return code -127
<seamonkey.exe>: Found error
<libs>: Found error
evaluation from h:\mozprgs\devtools\config\recurse.mk:44:44:14:0: command 'e:/mozstuff/mozbuild/python/python.exe h:/mozprgs/devtools/mozilla/build/pymake/pymake/../make.py -C app libs' failed, return code 2
h:\mozprgs\devtools\mozilla\config\recurse.mk:162:0: command 'e:/mozstuff/mozbuild/python/python.exe h:/mozprgs/devtools/mozilla/build/pymake/pymake/../make.py -C ../suite libs' failed, return code 2
h:\mozprgs\devtools\mozilla\config\rules.mk:599:0: command 'e:/mozstuff/mozbuild/python/python.exe h:/mozprgs/devtools/mozilla/build/pymake/pymake/../make.py libs' failed, return code 2
h:\mozprgs\devtools\objdir-sm\Makefile:52:0: command 'e:/mozstuff/mozbuild/python/python.exe h:/mozprgs/devtools/mozilla/build/pymake/pymake/../make.py -C mozilla default' failed, return code 2
h:\mozprgs\devtools\client.mk:391:0: command 'e:/mozstuff/mozbuild/python/python.exe h:/mozprgs/devtools/mozilla/build/pymake/pymake/../make.py -j4 -C h:/mozprgs/devtools/objdir-sm' failed, return code 2 

glandium over irc, provided a patch which fixes this issue.

(will attach a patch)
Attached patch patch (obsolete) — Splinter Review
Patch from glandium.
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
OS: Windows Vista → All
Attachment #8361465 - Flags: review?(Pidgeot18)
Attached patch patchSplinter Review
Attachment #8361465 - Attachment is obsolete: true
Attachment #8361465 - Flags: review?(Pidgeot18)
Attachment #8361468 - Flags: review?(Pidgeot18)
Attachment #8361468 - Flags: review?(Pidgeot18) → review+
Saw this error on WinXP debug Thunderbird comm-central:
c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\config\rules.mk:1005:0$ mozbuild.action.cl main  cl -FonsLDAPControl.obj -c -D_HAS_EXCEPTIONS=0 -I../../../mozilla/dist/stl_wrappers  -DMOZ_PREF_EXTENSIONS -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DZLIB_INTERNAL -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DNO_NSPR_10_SUPPORT -I../../../mozilla/dist/public/ldap -Ic:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/ldap/xpcom/src -I. -I../../../mozilla/dist/include -I../../../mozilla/dist/include/nsprpub  -Ic:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/objdir-tb/mozilla/dist/include/nspr -Ic:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/objdir-tb/mozilla/dist/include/nss        -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DDEBUG -D_DEBUG -DTRACING -Zi -O1 -Oy- -MDd           -FI ../../../mozilla/dist/include/mozilla-config.h -DMOZILLA_CLIENT c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/ldap/xpcom/src/nsLDAPControl.cpp
Error importing mozbuild.action.cl: No module named mozprocess.processhandler

so I'm going to check this patch in to fix this issue.
Pushed: https://hg.mozilla.org/comm-central/rev/50104122059c

Want this on branches, too? After all Bug 920353 was already checked in a while ago.
Target Milestone: --- → Thunderbird 29.0
This is long fixed.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.