Closed
Bug 960860
Opened 9 years ago
Closed 9 years ago
Don't include zlib.h from jsutil.h
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: luke, Assigned: luke)
References
Details
Attachments
(1 file)
13.40 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
This patch splits compression out into its own .cpp/.h pair. The s/compress/work/ renaming in jsscript.cpp is due to bug 960821.
Attachment #8361470 -
Flags: review?(n.nethercote)
![]() |
||
Comment 1•9 years ago
|
||
Comment on attachment 8361470 [details] [diff] [review] rm-compress-from-jsutil Review of attachment 8361470 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/vm/Compression.h @@ +16,5 @@ > +namespace js { > + > +class Compressor > +{ > + /* Number of bytes we should hand to zlib each compressMore() call. */ You don't think C++ comments are nicer?
Attachment #8361470 -
Flags: review?(n.nethercote) → review+
![]() |
Assignee | |
Comment 2•9 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #1) I was mostly just copy-pastin'. From discussions on dev.platform, it sounds like we might have a Great Style Normalization in our future anyway ;)
![]() |
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/56580a9e6ca6
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/56580a9e6ca6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•