Closed Bug 960860 Opened 7 years ago Closed 7 years ago

Don't include zlib.h from jsutil.h

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: luke, Assigned: luke)

References

Details

Attachments

(1 file)

rm-compress-from-jsutil
13.40 KB, patch
njn
: review+
Details | Diff | Splinter Review 
This patch splits compression out into its own .cpp/.h pair.  The s/compress/work/ renaming in jsscript.cpp is due to bug 960821.
Attachment #8361470 - Flags: review?(n.nethercote)
Blocks: 960367
Comment on attachment 8361470 [details] [diff] [review]
rm-compress-from-jsutil

Review of attachment 8361470 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Compression.h
@@ +16,5 @@
> +namespace js {
> +
> +class Compressor
> +{
> +    /* Number of bytes we should hand to zlib each compressMore() call. */

You don't think C++ comments are nicer?
Attachment #8361470 - Flags: review?(n.nethercote) → review+
(In reply to Nicholas Nethercote [:njn] from comment #1)
I was mostly just copy-pastin'.  From discussions on dev.platform, it sounds like we might have a Great Style Normalization in our future anyway ;)
https://hg.mozilla.org/mozilla-central/rev/56580a9e6ca6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.