960860 - Don't include zlib.h from jsutil.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: rm-compress-from-jsutil

This patch splits compression out into its own .cpp/.h pair.  The s/compress/work/ renaming in jsscript.cpp is due to bug 960821.

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 8361470 [details] [diff] [review]
rm-compress-from-jsutil

Review of attachment 8361470 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Compression.h
@@ +16,5 @@
> +namespace js {
> +
> +class Compressor
> +{
> +    /* Number of bytes we should hand to zlib each compressMore() call. */

You don't think C++ comments are nicer?

Comment 2

[Luke Wagner [:luke]]

(In reply to Nicholas Nethercote [:njn] from comment #1)
I was mostly just copy-pastin'.  From discussions on dev.platform, it sounds like we might have a Great Style Normalization in our future anyway ;)

Comment 3

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56580a9e6ca6

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/56580a9e6ca6