Closed Bug 960879 Opened 10 years ago Closed 10 years ago

[music2] Fix the tabs

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.4 S1 (14feb)

People

(Reporter: squib, Assigned: squib)

Details

(Whiteboard: [fxos:media])

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/15446
46 bytes, text/x-github-pull-request
dkuo
: review+
Details | Review 
Even though we're probably going to get rid of the tabs on the bottom of the screen, we might as well fix them now so that things are a bit more usable. Patch forthcoming.
This makes the tabs use the newer building blocks and copies the tab images from music1.
Attachment #8361500 - Flags: review?(dkuo)
Whiteboard: [fxos:media]
Target Milestone: --- → 1.4 S1 (14feb)
Comment on attachment 8361500 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15446

The patch looks good to me! Thanks for working on this, Jim.
Attachment #8361500 - Flags: review?(dkuo) → review+
Landed on master: f1898328514f40f2e23f271984e37e0b8e1b286b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: