Needinfo wilson since he touched the activity.js file last. I'm not sure who would be best able to fix this.
Created attachment 8361678 [details] [review] pull-request (master)
Comment on attachment 8361678 [details] [review] pull-request (master) Wilson, This patch fixes the immediate bug. It doesn't really address the underlying architectural issue that your Activity abstraction doesn't really do what you need it to do. You still have a method called check() that is really an addEventListener() for activity handlers. Except that the activity handler also gets called immediately if there is no pending activity at all. It is an awkward abstraction. Calling the handler code multiple times seems harmless, though, so not a high priority to clean it up, but it is something I hope you'll put on your list to do.
I understand this is a quick fix and could be better. Is the following spec something we can go by, or have I missed anything? Activity abstraction spec: 1. Should check for incoming activities and callback when the check is complete. 2. Should parse any activity data found during the check, formatting it so that makes sense to the camera app. 3. Should only run the incoming activity handler once (on app start). Camera app is not currently able to respond to incoming activities after boot, but I don't believe this to be a requirement. If it is we can add this functionality.
I believe this has since been fixed. Wilson: Do you have the bug number off-hand that fixed our Activity issues? Trying to go through and clean up some obsolete Camera bugs.
Fixed by bug 1001530