Closed Bug 961000 Opened 10 years ago Closed 10 years ago

Panels are sometimes mispositioned

Categories

(Add-on SDK Graveyard :: General, defect, P3)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86_64
All
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: phlsa, Assigned: zer0)

References

Details

Attachments

(1 file)

Screen Shot 2014-01-17 at 14.06.03.png
831.14 KB, image/png
Details 
Some Add-ons like bwinton's Snooze Tabs (http://people.mozilla.org/~bwinton/snoozetabs) have a glitch that causes the panel to be positioned in the middle of the window. I could only reproduce this on Windows, but I heard people complain about it on OS X too. This error shows up in the browser console when clicking the button:

TypeError: this.docShell is null
Stack trace:
get_contentWindow@chrome://global/content/bindings/general.xml:91
_waitForFrame@resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/philipp/AppData/Roaming/Mozilla/Firefox/Profiles/pgq5khia.default/extensions/jid1-snoozetabs@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/content/symbiont.js:124
listener@resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/philipp/AppData/Roaming/Mozilla/Firefox/Profiles/pgq5khia.default/extensions/jid1-snoozetabs@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/observer-service.js:39
Observer<.observe@resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/philipp/AppData/Roaming/Mozilla/Firefox/Profiles/pgq5khia.default/extensions/jid1-snoozetabs@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/system/events.js:74
As with other people, the issue can be solved by restarting the browser. The error in the browser console is also gone. Still, this could be the first run experience for many add-on users.
QA Contact: zer0
I'm pretty
Assignee: nobody → zer0
QA Contact: zer0
I'm pretty sure is the same issue of bug 940051.
(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #3)
> I'm pretty

wtf. :D
(In reply to Philipp Sackl [:phlsa] from comment #2)
> As with other people, the issue can be solved by restarting the browser. The
> error in the browser console is also gone. Still, this could be the first
> run experience for many add-on users.

This does suck but since the intention is to deprecate widgets entirely and the problem goes away after a restart unless there is a quick fix I'm not sure we can spend a lot of time on this.

What happens if you disable then enable the add-on while Firefox is running, does the problem re-occur?
(In reply to Dave Townsend (:Mossop) from comment #6)
> What happens if you disable then enable the add-on while Firefox is running,
> does the problem re-occur?

As the issue has disappeared with the restart, I can't reproduce it anymore and thus not test disabling the add-on. If I ever encounter the problem again, I'll try that.
Can you test it? It would explain if the problem occurs when the add-on is started at runtime (in the case of installation and enabling) and not at startup.
OK, I just checked:
Uninstalling and reinstalling the add-on causes the glitch to show up again.
Disabling and enabling does not fix the problem.
Restarting, as always, fixes the problem.

The problem also occurs on OS X.
OS: Windows 8.1 → All
Depends on: 987177
This bug is caused by bug 987177.
We could probably add a workaround for it - e.g. instead of checking the node's reference, just compare the node's id – but probably is better waiting for the real fix on platform side.
With bug 987177 fixed this bug seems resolved too, on latest Firefox Nightly.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: