Closed Bug 961027 Opened 11 years ago Closed 11 years ago

Can we import code from V8?

Categories

(mozilla.org :: Licensing, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

For bug 959597, I want to import V8's ARM simulator. We'll also be making some pretty big changes to it (style, bug fixes, integration, etc).

Bug 558799 also imported V8 code into SpiderMonkey, so I think it's allowed, but I'd like to be sure.

Also, if it is, should we add both Mozilla and V8 license headers?
OS: Mac OS X → All
Hardware: x86 → All
Importing code from V8 is fine. Please add the directories concerned to the list just above the V8 license at about:license#v8 . From the patch, it doesn't look like the files have a license header on them - is that correct? If it is, then please also add a LICENSE file in the top directory of your import with a copy of the V8 license.

Do not add Mozilla license headers; that would complicate the licensing situation and make it impossible for any of the changes we make to go back upstream. (Whether or not we plan to do this, others may want to.) Please continue to work on the code under its existing license.

Does that answer all your questions?

Gerv
Blocks: 959597
(In reply to Gervase Markham [:gerv] from comment #1)
> From the patch, it
> doesn't look like the files have a license header on them - is that correct?

The original files do have license headers, I just didn't copy that part of the files. I will add them of course when I post cleaned-up patches for review.

> Does that answer all your questions?

Yes, perfectly. Thank you very much!
Adds js/src/jit/arm to the list.
Assignee: gerv → jdemooij
Status: NEW → ASSIGNED
Attachment #8366847 - Flags: review?(gerv)
Comment on attachment 8366847 [details] [diff] [review]
Add directory to about:license

r=gerv.

Gerv
Attachment #8366847 - Flags: review?(gerv) → review+
https://hg.mozilla.org/mozilla-central/rev/7aca9bb221fc
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: