Closed Bug 961050 Opened 10 years ago Closed 10 years ago

reference to undefined property options.compression

Categories

(Toolkit Graveyard :: OS.File, defect)

x86
macOS
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: florian, Assigned: tareqakhandaker)

Details

(Whiteboard: [Async:ready][mentor=Yoric][lang=js])

Attachments

(1 file, 1 obsolete file)

JavaScript Warning: "reference to undefined property options.compression" {file: "resource://gre/modules/osfile/osfile_shared_front.jsm" line: 402}

http://hg.mozilla.org/mozilla-central/annotate/b53589696cf8/toolkit/components/osfile/modules/osfile_shared_front.jsm#l402
Whiteboard: [Async:ready][mentor=Yoric][lang=js]
Assignee: nobody → tareqakhandaker
I tested this patch by just doing a ./mach build to see if it build without errors.

I assumed that if the options object doesn't have a compression property, then we don't want to compress.

Am I missing anything?
Attachment #8362198 - Flags: review?(dteller)
Attachment #8362198 - Flags: review?(dteller) → review+
Comment on attachment 8362198 [details] [diff] [review]
reference_to_undefined_property_options.compression.patch

You are missing a similar if clause on line 332.
Attachment #8362198 - Flags: feedback-
Thanks for catching that.
Attachment #8362198 - Attachment is obsolete: true
Attachment #8369206 - Flags: review?(dteller)
Comment on attachment 8369206 [details] [diff] [review]
reference_to_undefined_property_options.compression.patch

Review of attachment 8369206 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks.
Tareq, do you have Try access?
Attachment #8369206 - Flags: review?(dteller) → review+
I don't have Try access.
Looks good. Tareq, are you ready for checkin-needed?
Yes.
https://hg.mozilla.org/integration/fx-team/rev/a9889e6a4da6
Keywords: checkin-needed
Whiteboard: [Async:ready][mentor=Yoric][lang=js] → [Async:ready][mentor=Yoric][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a9889e6a4da6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Async:ready][mentor=Yoric][lang=js][fixed-in-fx-team] → [Async:ready][mentor=Yoric][lang=js]
Target Milestone: --- → mozilla29
Target Milestone: mozilla29 → mozilla30
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: