Closed
Bug 961050
Opened 10 years ago
Closed 10 years ago
reference to undefined property options.compression
Categories
(Toolkit Graveyard :: OS.File, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: florian, Assigned: tareqakhandaker)
Details
(Whiteboard: [Async:ready][mentor=Yoric][lang=js])
Attachments
(1 file, 1 obsolete file)
1.56 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
JavaScript Warning: "reference to undefined property options.compression" {file: "resource://gre/modules/osfile/osfile_shared_front.jsm" line: 402} http://hg.mozilla.org/mozilla-central/annotate/b53589696cf8/toolkit/components/osfile/modules/osfile_shared_front.jsm#l402
Updated•10 years ago
|
Whiteboard: [Async:ready][mentor=Yoric][lang=js]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → tareqakhandaker
Assignee | ||
Comment 1•10 years ago
|
||
I tested this patch by just doing a ./mach build to see if it build without errors. I assumed that if the options object doesn't have a compression property, then we don't want to compress. Am I missing anything?
Attachment #8362198 -
Flags: review?(dteller)
Updated•10 years ago
|
Attachment #8362198 -
Flags: review?(dteller) → review+
Comment 2•10 years ago
|
||
Comment on attachment 8362198 [details] [diff] [review] reference_to_undefined_property_options.compression.patch You are missing a similar if clause on line 332.
Attachment #8362198 -
Flags: feedback-
Assignee | ||
Comment 3•10 years ago
|
||
Thanks for catching that.
Attachment #8362198 -
Attachment is obsolete: true
Attachment #8369206 -
Flags: review?(dteller)
Comment 4•10 years ago
|
||
Comment on attachment 8369206 [details] [diff] [review] reference_to_undefined_property_options.compression.patch Review of attachment 8369206 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, thanks. Tareq, do you have Try access?
Attachment #8369206 -
Flags: review?(dteller) → review+
Assignee | ||
Comment 5•10 years ago
|
||
I don't have Try access.
Comment 6•10 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=4a7855cdaafc
Comment 7•10 years ago
|
||
Looks good. Tareq, are you ready for checkin-needed?
Assignee | ||
Comment 8•10 years ago
|
||
Yes.
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a9889e6a4da6
Keywords: checkin-needed
Whiteboard: [Async:ready][mentor=Yoric][lang=js] → [Async:ready][mentor=Yoric][lang=js][fixed-in-fx-team]
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a9889e6a4da6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Async:ready][mentor=Yoric][lang=js][fixed-in-fx-team] → [Async:ready][mentor=Yoric][lang=js]
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Target Milestone: mozilla29 → mozilla30
Updated•11 months ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•