961050 - reference to undefined property options.compression

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[Florian Quèze [:florian]]

JavaScript Warning: "reference to undefined property options.compression" {file: "resource://gre/modules/osfile/osfile_shared_front.jsm" line: 402}

http://hg.mozilla.org/mozilla-central/annotate/b53589696cf8/toolkit/components/osfile/modules/osfile_shared_front.jsm#l402

Comment 1

[Tareq Khandaker]

Attachment: reference_to_undefined_property_options.compression.patch

I tested this patch by just doing a ./mach build to see if it build without errors.

I assumed that if the options object doesn't have a compression property, then we don't want to compress.

Am I missing anything?

Comment 2

[aleth [:aleth]]

Comment on attachment 8362198 [details] [diff] [review]
reference_to_undefined_property_options.compression.patch

You are missing a similar if clause on line 332.

Comment 3

[Tareq Khandaker]

Attachment: reference_to_undefined_property_options.compression.patch

Thanks for catching that.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8369206 [details] [diff] [review]
reference_to_undefined_property_options.compression.patch

Review of attachment 8369206 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks.
Tareq, do you have Try access?

Comment 5

[Tareq Khandaker]

I don't have Try access.

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Try: https://tbpl.mozilla.org/?tree=Try&rev=4a7855cdaafc

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Looks good. Tareq, are you ready for checkin-needed?

Comment 8

[Tareq Khandaker]

Yes.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/a9889e6a4da6

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9889e6a4da6