make dumpScreen always write to a file in MOZ_UPLOAD_DIR

RESOLVED FIXED in mozilla29

Status

Testing
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ted, Assigned: mtabara)

Tracking

unspecified
mozilla29
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Moved this patch from bug 749421 attachment 801885 [details] [diff] [review], since that bug is overwhelmed with patches. I r+ed a version of this patch but it needed rework post-bug 746243.

This patch simplifies dumpScreen so that it writes screenshot files to $MOZ_UPLOAD_DIR so blobber can upload them instead of dumping a data: URI to disk.
(Reporter)

Updated

4 years ago
Depends on: 749421
(Reporter)

Comment 1

4 years ago
Created attachment 8361806 [details] [diff] [review]
make dumpScreen always write to a file in MOZ_UPLOAD_DIR
Attachment #8361806 - Flags: review?(jmaher)
Comment on attachment 8361806 [details] [diff] [review]
make dumpScreen always write to a file in MOZ_UPLOAD_DIR

Review of attachment 8361806 [details] [diff] [review]:
-----------------------------------------------------------------

please remove automation.py.in::dumpScreen and reference the version in automationutils.py from all scripts.
Attachment #8361806 - Flags: review?(jmaher) → review-
(Reporter)

Comment 3

4 years ago
Created attachment 8363783 [details] [diff] [review]
make dumpScreen always write to a file in MOZ_UPLOAD_DIR

Neutered the automation.dumpScreen method, moved everything to automationutils.
Attachment #8363783 - Flags: review?(jmaher)
(Reporter)

Updated

4 years ago
Attachment #8361806 - Attachment is obsolete: true
Comment on attachment 8363783 [details] [diff] [review]
make dumpScreen always write to a file in MOZ_UPLOAD_DIR

Review of attachment 8363783 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8363783 - Flags: review?(jmaher) → review+
(Reporter)

Comment 5

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2c507997d55
Assignee: ted → tabara.mihai
https://hg.mozilla.org/mozilla-central/rev/e2c507997d55
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
(Reporter)

Updated

4 years ago
Depends on: 966858
You need to log in before you can comment on or make changes to this bug.