961204 - Remove the my_context bits from nsWindowSH::NewResolve

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

As far as we can tell, they're not really used.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the my_context bits from nsWindowSH::NewResolve and just use the passed-in cx for everything.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Same thing as diff -w

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8361888 [details] [diff] [review]
Remove the my_context bits from nsWindowSH::NewResolve and just use the passed-in cx for everything.

Review of attachment 8361888 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8361888 [details] [diff] [review]
Remove the my_context bits from nsWindowSH::NewResolve and just use the passed-in cx for everything.

Review of attachment 8361888 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDOMClassInfo.cpp
@@ +3371,5 @@
>      bool did_resolve = false;
>      bool ok = true;
>      JS::Rooted<JS::Value> exn(cx, JSVAL_VOID);
>  
> +    ok = JS_ResolveStandardClass(cx, obj, id, &did_resolve);

No need for the ok local anymore

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Let's have the browser start too

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Interdiff from previous patch

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8362016 [details] [diff] [review]
Let's have the browser start too

Review of attachment 8362016 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDOMClassInfo.cpp
@@ +3416,5 @@
>  
>      return NS_OK;
>    }
>  
> +  // WebIDL quickstubs handle location for us, but Xrays don't see those.  So if

This comment needs fixing. r=bholley with that.

Comment 8

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad626723a359 and then https://hg.mozilla.org/integration/mozilla-inbound/rev/6bff1bb5e277 to fix the review comment.  :(

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ad626723a359
https://hg.mozilla.org/mozilla-central/rev/6bff1bb5e277