961222 - fix documentation and indentation in Compiler.h

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix documentation and indentation in Compiler.h

Noticed both of these were wrong, might as well fix things up.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8361899 [details] [diff] [review]
fix documentation and indentation in Compiler.h

Review of attachment 8361899 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/Compiler.h
@@ +15,5 @@
> +    /*
> +     * This macro should simplify gcc version checking. For example, to check
> +     * for gcc 4.5.1 or later, check `#if MOZ_GCC_VERSION_AT_LEAST(4, 5, 1)`.
> +     */
> +#    define MOZ_GCC_VERSION_AT_LEAST(major, minor, patchlevel)          \

Hm, this define and the one above it are at the same indent level.  So this second one should be unindented by two spaces.  And if Assertions.h is guide, the comment should be unindented by one space, to put the '/' aligned with the 'd' in 'define'.

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc98b7a52884

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bc98b7a52884