Closed
Bug 961222
Opened 11 years ago
Closed 11 years ago
fix documentation and indentation in Compiler.h
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: froydnj, Unassigned)
Details
Attachments
(1 file)
|
1.78 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•11 years ago
|
||
Noticed both of these were wrong, might as well fix things up.
Attachment #8361899 -
Flags: review?(jwalden+bmo)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8361899 [details] [diff] [review]
fix documentation and indentation in Compiler.h
Review of attachment 8361899 [details] [diff] [review]:
-----------------------------------------------------------------
::: mfbt/Compiler.h
@@ +15,5 @@
> + /*
> + * This macro should simplify gcc version checking. For example, to check
> + * for gcc 4.5.1 or later, check `#if MOZ_GCC_VERSION_AT_LEAST(4, 5, 1)`.
> + */
> +# define MOZ_GCC_VERSION_AT_LEAST(major, minor, patchlevel) \
Hm, this define and the one above it are at the same indent level. So this second one should be unindented by two spaces. And if Assertions.h is guide, the comment should be unindented by one space, to put the '/' aligned with the 'd' in 'define'.
Attachment #8361899 -
Flags: review?(jwalden+bmo) → review+
|
|
Reporter | |
Comment 3•11 years ago
|
||
Flags: in-testsuite-
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•