Closed Bug 961252 Opened 10 years ago Closed 10 years ago

Inject `console` into sandbox by default

Categories

(Add-on SDK Graveyard :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

This prevents us from using SDK modules outside of our environment, as console is required in some modules. We should fall back and create a console if none are provided, as everyone will expect this to exist.
Attached file GH PR 1355
Irakli, sending this to you to get your thoughts on this.
Attachment #8361994 - Flags: review?(rFobic)
Attachment #8361994 - Flags: review?(rFobic) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d3bcee68a75d198ac6fcfc7039eadf732eef2e4a
Bug 961252 Inject 'console' as global by default

https://github.com/mozilla/addon-sdk/commit/f210f4582057e5efce96dded05d57a9849345c08
Merge pull request #1355 from jsantell/961252-inject-console-by-default

fix Bug 961252 Inject 'console' as global by default, r=@gozala
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
OS: Mac OS X → All
Hardware: x86 → All
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: