961270 - Show compatibility error if an add-on uses downloads-indicator

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P1)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 847863, the downloads-indicator DOM node was removed in favor of downloads-button. We need to flag all instances of this identifier being used and show an error.

This is a compatibility error, so the add-on should not be upgraded in this case.

Message:

The downloads-indicator node was removed from the DOM. You should be able to use downloads-button instead. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=845408

Affected add-on:

https://addons.mozilla.org/addon/stratiform/

You can use these previous compatibility validation bugs as reference:
https://bugzilla.mozilla.org/buglist.cgi?status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=[fx26]&product=addons.mozilla.org&list_id=9221892

For Firefox 27 we only need this one. If possible I'd like this in the next push, but it can be delayed if necessary.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: uses-downloads-indicator.xpi

That add-on does not seem to be invalid. It references `#downloads-indicator-icon` in the CSS but that does not appear to be going away. I had to modify an add-on to get errors out of it, it is attached.

Running `./addon-validator --for-appversions '{"{ec8030f7-c20a-464f-9b0e-13a3a9e97384}": ["27.*"]}' uses-downloads-indicator.xpi -o json | tail -n 1 | python -mjson.tool` against my uploaded add-on gives:

{
    "compatibility_summary": {
        "errors": 3, 
        "notices": 0, 
        "warnings": 0
    },
    ....
}

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Ah, sorry for the bad example. If the modified version is working okay, I'm okay with the patch.

Comment 3

[Mark Striemer [:mstriemer]]

https://github.com/mstriemer/amo-validator/commit/ec1dfddc3aececc4bd42d2670493091d7de11aad

Comment 4

[Mark Striemer [:mstriemer]]

This may be an issue but I'm not sure. The CSS test is not scoped by Firefox version so it is run for every version. If you upload an addon that states it only supports up to 26 or lower you will still get a hard validation error.

`./addon-validator --for-appversions '{"{ec8030f7-c20a-464f-9b0e-13a3a9e97384}": ["26.*"]}' uses-downloads-indicator.xpi` produces:

Summary:
------------------------------
Detected type: Extension/Multi-Extension
------------------------------
Test failed! Errors:

Error:	The `#downloads-indicator` node was removed from the DOM.

... snip ...


So is that a problem or is it expected?

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

That's a problem, and it caused bug 965156, apparently. This validation should only appear as an error when doing compatibility checks for Firefox 26. For all other cases it should only appear as a compatibility warning. That's how all previous compatibility checks have worked.

Comment 6

[Mark Striemer [:mstriemer]]

Should this always be a warning? If you want to support both 26 and 27 you will still need to handle #downloads-indicator, won't you?