Closed
Bug 96140
Opened 23 years ago
Closed 23 years ago
Need small icon for syst. tray for Help
Categories
(SeaMonkey :: Help Documentation, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.6
People
(Reporter: rudman, Assigned: marlon.bishop)
Details
Attachments
(3 files)
9.03 KB,
application/zip
|
Details | |
1.12 KB,
patch
|
hewitt
:
superreview+
|
Details | Diff | Splinter Review |
695 bytes,
patch
|
Details | Diff | Splinter Review |
Help should have a small icon associated with it, so a user can see the icon and name in the Windows system tray. Other components have such an icon. The Help window currently looks like just another Navigator window. It could be the case that a user has to toggle back and forth between a Nav window and the Help window, so having the icon in the syst. tray will make that task easier.
Assignee | ||
Comment 1•23 years ago
|
||
targeting to 0.9.4. should be on it this week
Summary: Need small icon for syst. tray for Help → Need small icon for syst. tray for Help
Target Milestone: --- → mozilla0.9.4
Assignee | ||
Comment 2•23 years ago
|
||
Joe -> The help icons are ready to go for both mac and Win. Can you take a look in the usual desktop icon folder for these?
Assignee | ||
Comment 3•23 years ago
|
||
Comment 5•23 years ago
|
||
Comment 6•23 years ago
|
||
cc'ing jj (as someone Marlon suggested is both helpful and knowledgeable about this stuff). The patch above has the sys tray icon for windows, but I don't know how to deal with the mac side. Can you help or let me know what needs to be done? Thanks a lot
Comment 7•23 years ago
|
||
Woops. Sorry, jj. Mac doesn't need this after all, since it's just the sys tray icon we're doing and not an application icon on windows.
Comment 8•23 years ago
|
||
Comment on attachment 48328 [details] [diff] [review] adding help icon on windows I don't see the patch for changing the window id, but if Ian did what he told me he did a minute ago, then sr=hewitt ;)
Attachment #48328 -
Flags: superreview+
Comment 9•23 years ago
|
||
Comment 10•23 years ago
|
||
r=andreww - looks ok after explaination.
Comment 11•23 years ago
|
||
The change to the help window id is on the mozilla side. I've checked and there is no other reference to or grabbing of the id in the UI, so requesting a=asa on this update to get the help.ico to show up in the sys tray on the commercial side for the help viewer. TIA, Asa.
Status: NEW → ASSIGNED
Comment 12•23 years ago
|
||
Though it's not a stop ship, I'd love to get this simple fix in. Adding nsbranch to the whiteboard and figuring out who can nsbranch+ it on rudman's behalf while he's gone.
Whiteboard: nsbranch
Comment 13•23 years ago
|
||
I will add nsbranch+ since this helps in usability when the user has the Help window open along with other browser windows, etc. Ian, this bug still needs a r/sr on the latest patch (above). Is this fix only on commercial side then? Shouldn't this bug be on bugscape?
Keywords: nsbranch+
Whiteboard: nsbranch
Comment 14•23 years ago
|
||
If this is not a stop ship, then it does not meet our criteria for the past 2 weeks. Propose this one waits for the next boat.
Comment 15•23 years ago
|
||
It isn't a stop ship, but it's so bite-sized and innocuous and pretty-making that I am going to call in and suborn the PDT for it today. Hope that's OK.
Comment 16•23 years ago
|
||
ah, never mind. deferring to jaime's suggestion. we'll get this in next time. removing nsbranch+ on this cosmetic fix.
Keywords: nsbranch+
Comment 17•23 years ago
|
||
Let's get this in on the trunk (pending any mozilla.org rules on checkin, if any). Perhaps we can try to get this one after its been on the trunk (no promises, but more of a chance).
Comment 18•23 years ago
|
||
Checked this in on the trunk.
Assignee | ||
Comment 19•23 years ago
|
||
looking at my 0.9.5 buglist - is this one verified yet?
Comment 20•23 years ago
|
||
Verified trunk build 2001-10-04-09-trunk w2k (Leaving as asigned, hoping it will get into branch?)
Comment 21•23 years ago
|
||
jaime - what do you think of this bug getting in?
Comment 22•23 years ago
|
||
Sounds like usability/polish type stuff to me, and it hasn't been nominated by anyone as stop ship type bug ... argh ... at this date ... i'd have to say no <reluctanty> :-(
Comment 24•23 years ago
|
||
Sol - Are you ok, with this polish bug not making the 094 branch?
Comment 25•23 years ago
|
||
I'm OK with this not making the 094 branch.
Assignee | ||
Comment 26•23 years ago
|
||
this has already been checked into the tree according to IAN. Marking FIxed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•