Closed Bug 961468 Opened 10 years ago Closed 10 years ago

No need to check file existence twice in _readManifests

Categories

(Core Graveyard :: DOM: Apps, defect)

Product:
Core Graveyard
Component:
DOM: Apps
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: marco, Assigned: marco)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Alternative patch
1.91 KB, patch
fabrice
: review+
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review 
I've just noticed that _readManifests is calling nsIFile::exists on the same file twice.
Attachment #8362206 - Flags: review?(fabrice)
Attachment #8362206 - Flags: review?(fabrice) → review+
This is an alternative patch that avoids completely to check for file existence in _readManifests (because it's already done by loadJSONAsync, that returns null if the file doesn't exist).
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #8367604 - Flags: review?(fabrice)
Attachment #8367604 - Flags: review?(fabrice) → review+
Attachment #8362206 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a2c030eb1c50
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: