Closed Bug 961468 Opened 6 years ago Closed 6 years ago
No need to check file existence twice in _read
I've just noticed that _readManifests is calling nsIFile::exists on the same file twice.
Attachment #8362206 - Flags: review?(fabrice)
Attachment #8362206 - Flags: review?(fabrice) → review+
This is an alternative patch that avoids completely to check for file existence in _readManifests (because it's already done by loadJSONAsync, that returns null if the file doesn't exist).
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #8367604 - Flags: review?(fabrice)
Attachment #8367604 - Flags: review?(fabrice) → review+
Attachment #8362206 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.