961505 - use the mid-point as boundary for xhdpi and beyond as well

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Andreas Gal :gal]

Comment on attachment 8362257 [details] [diff] [review]
patch

This makes the nexus-5 look a ton better. Please review and land if you agree.

Comment 3

[Andreas Gal :gal]

PS: device.mk currently selects the 1.5x assets and that should be 2.

Comment 4

[Andreas Gal :gal]

This is the 1.5 that should be set to 2:

https://github.com/mozilla-b2g/device-hammerhead/blob/b2g-4.4.2_r1/device.mk

Comment 5

[Andreas Gal :gal]

review ping

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/b2g-inbound/rev/11fd3aaa8320

I guess it stays the device-hammerhead part before closing this bug.

Comment 7

[Michael Wu [:mwu]]

I've bumped the scale to 2.0. 2.5 would be ideal, but I'm not sure if the gaia asset selection code does the right thing.

I think this math is actually a bit off - doesn't this give us a 3x scale rather than 2.5x? I missed this bug, so I filed bug 963929 which uses slightly different math so we can get the scale in increments of .5 rather than 1.0. This ends up giving the nexus 5 a 2.5x scale.

Comment 8

[Michael Wu [:mwu]]

I just tried 3.0x scale on the n5 - looks pretty good, actually.

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/11fd3aaa8320