All users were logged out of Bugzilla on October 13th, 2018

[TABLET] Support specifying target device type in Gaia build script.

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dliang, Assigned: GaryChen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We want to have a proper variable to control the GAIA build distribution.
Idea is below:
1. Define the device type in device config file, it shuold be TARGET_DEVICE_TYPE or some proper varuable.
2. In GAIA makefile, if TARGET_DEVICE_TYPE is equal as tablet, it will build tablet distribution; if TARGET_DEVICE_TYPE is equal as TV, it will build TV distribution.
(Reporter)

Updated

5 years ago
Blocks: 957957

Updated

5 years ago
Summary: [TABLET] Support GAIA tablet distribution → [TABLET] Support specifying target device type in Gaia build script.

Comment 1

5 years ago
@Yuren: any thought of the variable?
Flags: needinfo?(yurenju.mozilla)
yeah that's variable looks good to me.
Flags: needinfo?(yurenju.mozilla)
(Reporter)

Comment 3

5 years ago
I found there is similar definition in Android, "PRODUCT_CHARACTERISTICS := tablet" in device.mk.
Do we need to create other one for B2G?
Flags: needinfo?(ehung)
(Reporter)

Updated

5 years ago
Flags: needinfo?(yurenju.mozilla)
I'm good with PRODUCT_CHARACTERISTICS if gecko/gonk use the same variable to decide the product type. could you needinfo gecko/gonk guys to confirm it?
Flags: needinfo?(yurenju.mozilla)
(Reporter)

Comment 5

5 years ago
Pre-discussed with Marco, we need to avoid pollution of build flag in aosp, so we suggest to have a sepecific flag for B2G, such B2G_DEVICE_TYPE.

Comment 6

5 years ago
I'm good at any variable name, as long as it's not too specific for a device type.
Flags: needinfo?(ehung)
offline discussed, we use GAIA_DEVICE_TYPE
Taken first.
Assignee: nobody → gchen
Created attachment 8395537 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/17504

Hi Yuren,
   Please help to review my patch and give me some feedback.
   I prefer to add more 'test case' on bug 979787 but not on this bug.
   How do you think?
Attachment #8395537 - Flags: review?(yurenju.mozilla)
Component: General → Gaia::Build
(Reporter)

Updated

5 years ago
Blocks: 987489
(Reporter)

Updated

5 years ago
No longer blocks: 957957
Comment on attachment 8395537 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/17504

agree, r=yurenju
Attachment #8395537 - Flags: review?(yurenju.mozilla) → review+
Landed in master:
https://github.com/mpizza/gaia/commit/6c97c13fd096ef0d722a13777c76cd7541bba425

thanks~
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Blocks: 903304
You need to log in before you can comment on or make changes to this bug.