961563 - [TABLET] Support specifying target device type in Gaia build script.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Danny Liang [:dliang]]

We want to have a proper variable to control the GAIA build distribution.
Idea is below:
1. Define the device type in device config file, it shuold be TARGET_DEVICE_TYPE or some proper varuable.
2. In GAIA makefile, if TARGET_DEVICE_TYPE is equal as tablet, it will build tablet distribution; if TARGET_DEVICE_TYPE is equal as TV, it will build TV distribution.

Comment 1

[Evelyn Hung]

@Yuren: any thought of the variable?

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

yeah that's variable looks good to me.

Comment 3

[Danny Liang [:dliang]]

I found there is similar definition in Android, "PRODUCT_CHARACTERISTICS := tablet" in device.mk.
Do we need to create other one for B2G?

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I'm good with PRODUCT_CHARACTERISTICS if gecko/gonk use the same variable to decide the product type. could you needinfo gecko/gonk guys to confirm it?

Comment 5

[Danny Liang [:dliang]]

Pre-discussed with Marco, we need to avoid pollution of build flag in aosp, so we suggest to have a sepecific flag for B2G, such B2G_DEVICE_TYPE.

Comment 6

[Evelyn Hung]

I'm good at any variable name, as long as it's not too specific for a device type.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

offline discussed, we use GAIA_DEVICE_TYPE

Comment 8

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Taken first.

Comment 9

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/17504

Hi Yuren,
   Please help to review my patch and give me some feedback.
   I prefer to add more 'test case' on bug 979787 but not on this bug.
   How do you think?

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8395537 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/17504

agree, r=yurenju

Comment 11

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Landed in master:
https://github.com/mpizza/gaia/commit/6c97c13fd096ef0d722a13777c76cd7541bba425

thanks~