Closed Bug 961563 Opened 7 years ago Closed 7 years ago
[TABLET] Support specifying target device type in Gaia build script
46 bytes, text/x-github-pull-request
|Details | Review|
We want to have a proper variable to control the GAIA build distribution. Idea is below: 1. Define the device type in device config file, it shuold be TARGET_DEVICE_TYPE or some proper varuable. 2. In GAIA makefile, if TARGET_DEVICE_TYPE is equal as tablet, it will build tablet distribution; if TARGET_DEVICE_TYPE is equal as TV, it will build TV distribution.
Summary: [TABLET] Support GAIA tablet distribution → [TABLET] Support specifying target device type in Gaia build script.
@Yuren: any thought of the variable?
yeah that's variable looks good to me.
I found there is similar definition in Android, "PRODUCT_CHARACTERISTICS := tablet" in device.mk. Do we need to create other one for B2G?
I'm good with PRODUCT_CHARACTERISTICS if gecko/gonk use the same variable to decide the product type. could you needinfo gecko/gonk guys to confirm it?
Pre-discussed with Marco, we need to avoid pollution of build flag in aosp, so we suggest to have a sepecific flag for B2G, such B2G_DEVICE_TYPE.
I'm good at any variable name, as long as it's not too specific for a device type.
offline discussed, we use GAIA_DEVICE_TYPE
Assignee: nobody → gchen
Hi Yuren, Please help to review my patch and give me some feedback. I prefer to add more 'test case' on bug 979787 but not on this bug. How do you think?
Attachment #8395537 - Flags: review?(yurenju.mozilla)
Component: General → Gaia::Build
Comment on attachment 8395537 [details] [review] pull request: https://github.com/mozilla-b2g/gaia/pull/17504 agree, r=yurenju
Attachment #8395537 - Flags: review?(yurenju.mozilla) → review+
Landed in master: https://github.com/mpizza/gaia/commit/6c97c13fd096ef0d722a13777c76cd7541bba425 thanks~
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.