961719 - Remove fields we don't need in Webapp._meta.translated_fields

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P3)

Description

[Mathieu Pillard [:mat]]

The translation app uses <model>._meta.translated_fields to know which fields are translation fields on a model, to fetch them dynamically for each instance in each db query made (in the transformer).

For Webapps, because we inherit from Addon, we have (in mkt/webapps/models.py):
# Pull all translated_fields from Addon over to Webapp.
Webapp._meta.translated_fields = Addon._meta.translated_fields

But there are some Addon fields that we don't care about at all in Marketplace. We should remove those fields Webapp._meta.translated_fields to avoid processing them, they'll always be NULL anyway. This would make the SQL queries generated by the translations app in Marketplace a little less verbose, and hopefully very slightly improve performance (less useless joins to try to make for the db)

Comment 1

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/bbf00814785910f4c07013ce2cd99e9a6cb61719