961750 - Project backup refresh dialog shows up when I clicked leave on unload dialog

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

TLDR: I'm thinking we should only load the project backup dialog if the project hits an error or fails to save.

bug 924398 landed project backups, and but not on prod yet. The following report is only true if you're using master.

If I go to leave an unsaved project, an unload dialog comes up saying something along the lines of "are you sure you want to leave, you have unsaved data you'll lose".

If they click that they want to leave, they have discarded their changes, and don't want the backup loaded.

When they refresh that project, it brings up the project backup dialog, asking if they want to load the backup, but they already discarded it.

STRs (not on prod yet):

1. Load a fresh project.
2. Save it.
3. Make a change.
4. Hit refresh.
5. Confirm that you want to leave.

Expected: on the refresh, the project should be loading the last saved version of that project.
Actual: the project backup dialog comes up asking if I want to load a backup. At this point it must be confusing as to what backup that is. I know I would be scared to click either button as I don't know which data is associated with them anymore, and if I click the wrong one I may think I am going to lose something. Why would I think it is going to load the data I had when I left as I think that data is discareded.

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/422

So, this is still a proposal at this point, but you can probably tell by now I'm pushing pretty hard on this.

I'm open to critisim on this, don't be afraid to shoot it down.

Comment 2

[Matthew Schranz [:mjschranz]]

Comment on attachment 8362571 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/422

Comments.

I'm not too against this though. It's been so long since we last had a serious discussion about what we want from this that I'm starting to agree with simplifying it for now and then moving towards additions when the need arises.

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 8362571 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/422

Arg, updated but forgot to update the ticket :(

Comment 4

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/caa1c46ce9ceec788ee82659bfa5d26b49693f7b

Needs verification.