961758 - [Lockscreen] Intermittent NS_ERROR_UNEXPECTED error

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Mike Pennisi [:jugglinmike]]

About one month ago, the Clock application's integration tests failed due to a
Lockscreen-related error [1]. This error originated from line 1092 of
lockscreen.js [1]. That file has since changed, but the originating function
has not been modified since the error was discovered [3].

Because the reporter of this error reverted the Clock tests [4], those tests
cannot land until this bug is resolved.

[1] https://travis-ci.org/mozilla-b2g/gaia/jobs/15077387
[2] https://github.com/mozilla-b2g/gaia/blob/bfc00fb75030f89af41a1408c6799f67c510a208/apps/system/js/lockscreen.js#L1092
[3] https://github.com/mozilla-b2g/gaia/blob/bb7eb43d9241874ae801296e67b8d7edcda2af2a/apps/system/js/lockscreen.js#L952-L959
[4] https://bugzilla.mozilla.org/show_bug.cgi?id=907177#c29

Comment 1

[Marcus Cavanaugh [:mcav]]

This is reproducible in Nightly, with the following two lines of code
typed in the console:

l = navigator.mozSettings.createLock();
l.set({'lockscreen.locked': false});

// [Exception... "Unexpected error" nsresult: "0x8000ffff
// (NS_ERROR_UNEXPECTED)" location: "JS frame :: debugger eval code ::
// <TOP_LEVEL> :: line 1" data: no]

Comment 2

[Mike Pennisi [:jugglinmike]]

Hey Marcus, thanks for giving this a look.

I can reproduce the same error, but I think that is unrelated--it seems to be caused by executing that code from the console (specifically the part about "JS frame :: debugger eval code ::"). If you insert the same statements into the application itself (either at startup or after an arbitrary delay), no error is thrown.

I'm trying to reproduce this in b2g-desktop (since that is the integration test environment), but I haven't been able to do so yet. I think we could use the insight of one of the system application developers because this is an intermittent problem--it only occurred once after many integration test runs.

Comment 3

[Mike Pennisi [:jugglinmike]]

Hi Tim,

I believe this bug is pretty low-level (originating somewhere from Gecko), but
it also seems to be fixed.

For background: I've been digging around in MXR, but because it is
intermittent, I don't expect to find a straightforward problem. More likely,
this is caused by some aberrant state, and diagnosing this will likely require
a lot more familiarity with the code base than I have.

I stepped through the build log on TravisCI [1] starting today (January 21,
2014) and working backwards to when my tests were removed (December 7, 2013)
[2]. Gaia's Marionette-JS tests failed intermittently due to this bug until
December 10th--no integration test has failed for this reason since that date.

In other words, it looks as though this problem was been resolved. This
evidence is sufficient for me to unblock bug 961758, but I will let you decide
if it is worthwhile to do any forensics before closing.

I'm including a few of the final reported failures in case it helps with
bisecting:

- Dec 10, 2013 11:52 AM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15231540
- Dec 10, 2013 11:31 AM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15233834
- Dec 10, 2013 11:08 AM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15232981
- Dec 10, 2013 08:17 AM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15224201
- Dec 10, 2013 04:34 AM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15215044
- Dec 10, 2013 03:19 AM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15212586
- Dec 10, 2013 01:48 AM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15209910
- Dec 10, 2013 12:03 AM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15207415
- Dec 10, 2013 12:03 AM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15207349
- Dec 09, 2013 11:57 PM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15207265
- Dec 09, 2013 11:31 PM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15206643
- Dec 09, 2013 11:11 PM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15206185
- Dec 09, 2013 09:37 PM - https://travis-ci.org/mozilla-b2g/gaia/jobs/15203211

[1] https://travis-ci.org/mozilla-b2g/gaia/builds
[2] https://github.com/mozilla-b2g/gaia/commit/1abda08e450cb66a61a31bdcfd3352e2df9d9ace

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Sorry for the late reply. I have no opinion on whatever you decided.

Comment 5

[BMO Automation]

Firefox OS is not being worked on