Closed Bug 961776 Opened 6 years ago Closed 6 years ago

Event fluffing code should take into account the new role=key

Categories

(Core Graveyard :: File Handling, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: etienne, Assigned: etienne)

References

Details

Attachments

(1 file, 1 obsolete file)

A new role=key was introduced in bug 808596.


For event fluffing heuristics |IsElementClickable| should probably return true for role=key elements.
Assignee: nobody → etienne
Attachment #8380660 - Flags: review?(roc)
Comment on attachment 8380660 [details] [diff] [review]
bug-961776-role-key-is-clickable.patch

Review of attachment 8380660 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/PositionedEventTargeting.cpp
@@ +203,5 @@
>      }
>      if (content->AttrValueIs(kNameSpaceID_None, nsGkAtoms::role,
> +                             nsGkAtoms::button, eIgnoreCase) ||
> +        content->AttrValueIs(kNameSpaceID_None, nsGkAtoms::role,
> +                             nsGkAtoms::key, eIgnoreCase)) {

Use FindAttrValueIn.
Attachment #8380660 - Flags: review?(roc) → review-
Attached patch Patch v2Splinter Review
Thanks! new version.
Attachment #8380660 - Attachment is obsolete: true
Attachment #8381370 - Flags: review?(roc)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2cb3948fb588
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.