961798 - reconfigure: TypeError: this.window is null in BrowserTabActor.prototype._setJavascriptEnabled @ devtools/server/actors/webbrowser.js : 807

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Mihai Sucan [:msucan]]

I get the following exception when I quit the browser:

onPacket threw an exception: Error: Server did not specify an actor, dropping packet: {"error":"unknownError","message":"error occurred while processing 'reconfigure: TypeError: this.window is null\nStack: BrowserTabActor.prototype._setJavascriptEnabled@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/mihai/src/mozilla/fx-team/toolkit/devtools/server//main.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:807\nBrowserTabActor.prototype._toggleJsOrCache@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/mihai/src/mozilla/fx-team/toolkit/devtools/server//main.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:775\nBrowserTabActor.prototype.onReconfigure@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/mihai/src/mozilla/fx-team/toolkit/devtools/server//main.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:761\nDSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/mihai/src/mozilla/fx-team/toolkit/devtools/server//main.js:1018\nLDT_send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/server/transport.js:258\nmakeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.jsm -> resource://gre/modules/devtools/DevToolsUtils.js:76\n"}
Stack: DebuggerClient.prototype.onPacket/<@resource://gre/modules/devtools/dbg-client.jsm:674
resolve@resource://gre/modules/commonjs/sdk/core/promise.js:118
then@resource://gre/modules/commonjs/sdk/core/promise.js:43
then@resource://gre/modules/commonjs/sdk/core/promise.js:153
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:723
LDT_send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/server/transport.js:258
makeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.jsm -> resource://gre/modules/devtools/DevToolsUtils.js:76


STR:
1. open the devtools for any tab.
2. switch to the options panel.
3. ctrl-q (quit the browser).
4. see the exception in the terminal. You might need devtools.debugger.log=true.

The options panel does not need to be active. You can switch to any other tab after that. The only requirement for the exception to occur is that you have switched to it at least once.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

So we just need to add:
  if (this.window) {
    ...
  }

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Yep, good first bug. If someone picks it up before Mike returns from PTO, I can mentor them.

Comment 3

[Peiyong Lin[:lpy](UTC+8)]

I would like to take this bug. But I am not sure what I should do if |!this.window|. Just do nothing?

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Yes, that's right. If there is no usable way to get to the docshell, then both methods should do nothing.

Comment 5

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug961798.patch

Thank you past :)

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

You need to give _setCacheEnabled the same treatment.

Comment 7

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug961798.patch

Thanks.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8363066 [details] [diff] [review]
bug961798.patch

Review of attachment 8363066 [details] [diff] [review]:
-----------------------------------------------------------------

I'll take it, as Mike is on holiday.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/a7ec92db9f0b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a7ec92db9f0b