Web tests don't work on b2g

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

Two problems:

1. We're not calling the WebTest constructor.
2. (only a problem in certain cases) WebTests require wifi, and if --no-sync-time is specified we don't connect to a wifi network.
Created attachment 8362656 [details] [diff] [review]
Fix web tests on b2g;r=davehunt
Attachment #8362656 - Flags: review?(dave.hunt)
Note the above patch builds on work done in bug 960063.
Comment on attachment 8362656 [details] [diff] [review]
Fix web tests on b2g;r=davehunt

Review of attachment 8362656 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Bug 960985 has caused minor conflicts, but I was able to apply this and test it. I'm running with --no-capture, and on Hamachi I get the following message:

ERROR:root:Could not get actions for commandset 'default', model 'ALCATEL ONE TOUCH FIRE'

So long as these are okay, this looks good to me with or without the comment addressed.

::: src/eideticker/eideticker/runtest.py
@@ +132,3 @@
>          device.setupMarionette()
>  
> +        if sync_time or test.requires_wifi:

Could we fail with a suitable message if a wifi settings file has not been provided?
Attachment #8362656 - Flags: review?(dave.hunt) → review+
Pushed with a bit of extra logic to catch the case you mentioned:

https://github.com/mozilla/eideticker/commit/566a0032ecc6d26abe9912633463740c3bebbbd1

I filed bug 962169 as a follow up to deal with the error that you mentioned.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

a year ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.