961870 - [system] Whitespace missing before privacy policy in "What's in a crash report?" page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Boot2Gecko 1.3.0.0-prerelease 20140118 on Keon

The whitespace before "privacy policy" in the "What's in a crash report?" page is missing.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: pull request, v1

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: pull request, v2

Update localization note.

Comment 3

[Ton [:Tonnes]]

Note that these trailing spaces in settings and system.properties actually have been and probably should be there in v1.2 (note the comment line about trailing spaces above them) but were silently removed in bug 816152 and bug 860660 for some reason. If that shouldn’t have happened, it might be easier to consider them unwanted typos and add them back to the current entities, saving the need to change them. A message to the newsgroup would be welcome in that case.

Comment 4

[Axel Hecht [:Pike]]

Agreed, we should do this without key changes.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: pull request, v3

Comment 6

[Ton [:Tonnes]]

This should probably apply to both system.properties and settings.properties (at least when the latter is still used) and to any version.

Comment 7

[Fabien Cazenave [:kaze]]

I second that: please fix it in the Settings app as well.

As a side note, I think it would be more readable if the trailing space was a `\u20

Comment 8

[Fabien Cazenave [:kaze]]

Comment on attachment 8363962 [details] [review]
pull request, v3

Please add a trailing \u20 in both the System and Settings app, and re-flag me. Thanks!

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v4

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: pull request, v5

Comment 11

[Fabien Cazenave [:kaze]]

Comment on attachment 8366585 [details] [review]
pull request, v5

thanks for your patience :-)

Comment 12

[Fabien Cazenave [:kaze]]

Merged on master: https://github.com/mozilla-b2g/gaia/commit/792d7050094da9a2bc75848ac24279ef9c6954ef

Comment 13

[Stefan Plewako [:stef]]

Don't expect that it will be fixed in l10n without updating string ids…

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Posted a notice to localizers on mozilla.dev.l10n mailing list on 2014-02-03.