Closed
Bug 961970
Opened 11 years ago
Closed 11 years ago
[UITest] change layout with Building Blocks
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tjao, Assigned: tjao)
References
Details
Attachments
(1 file)
Use header & lists from Building Blocks. Also adjust layout a little bit.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8363532 -
Flags: review?(gasolin)
|
||
Comment 2•11 years ago
|
||
I found the buttons in API/contacts are piled.
You can try to include button styles in such panels to fix it.
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #2)
> I found the buttons in API/contacts are piled.
> You can try to include button styles in such panels to fix it.
For simplicity, I would like to handle the overall framework only in this bug. Refactoring for UI/API/HW tests will be filed as other bugs.
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8363532 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15547
sounds reasonable to me, r+
Attachment #8363532 -
Flags: review?(gasolin) → review+
|
|
||
Comment 5•11 years ago
|
||
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/5f7002e7a69a15f72aea296d47beb4b0205a4346
thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•