Closed Bug 961970 Opened 10 years ago Closed 10 years ago

[UITest] change layout with Building Blocks

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tjao, Assigned: tjao)

References

Details

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/15547
46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review 
Use header & lists from Building Blocks. Also adjust layout a little bit.
Assignee: nobody → tjao
Blocks: 958431

        Attachment #8363532 -
        Flags: review?(gasolin)

    
    

    
  
I found the buttons in API/contacts are piled.
You can try to include button styles in such panels to fix it.

    
    

    
  
(In reply to Fred Lin [:gasolin] from comment #2)
> I found the buttons in API/contacts are piled.
> You can try to include button styles in such panels to fix it.

For simplicity, I would like to handle the overall framework only in this bug. Refactoring for UI/API/HW tests will be filed as other bugs.

    
    

    
  
Comment on attachment 8363532 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15547

sounds reasonable to me, r+

        Attachment #8363532 -
        Flags: review?(gasolin) → review+

    
    

    
  
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/5f7002e7a69a15f72aea296d47beb4b0205a4346

thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: